Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd (#197) #213

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

vdahiya12
Copy link
Contributor

@vdahiya12 vdahiya12 commented Aug 25, 2021

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
Merging this in 202012 branch because there was a merge conflict in original PR
#197

Description
This PR integrates vendor specific class objects inside xcvrd for Y-Cable API's to be called.
Detailed designed document can be found sonic-net/SONiC#757

Motivation and Context
Basically xcvrd now has an interface for Y-Cable to interact with PMON docker and HOST
which can be uniform across all vendors. As part of this refactor, we will be moving towards a model where only xcvrd interacts with the cables/transceivers, and host-side processes will communicate with xcvrd rather than with the devices directly with Y-Cable.

How Has This Been Tested?
Ran the changes on Arista7050cx3 switch, making changes inside the container.

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

Description

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

…for calling Y-Cable API's inside xcvrd (sonic-net#197)

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

Description
This PR integrates vendor specific class objects inside xcvrd for Y-Cable API's to be called.
Detailed designed document can be found sonic-net/SONiC#757

Motivation and Context
Basically xcvrd now has an interface for Y-Cable to interact with PMON docker and HOST
which can be uniform across all vendors. As part of this refactor, we will be moving towards a model where only xcvrd interacts with the cables/transceivers, and host-side processes will communicate with xcvrd rather than with the devices directly with Y-Cable.

How Has This Been Tested?
Ran the changes on Arista7050cx3 switch, making changes inside the container.

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12 and others added 2 commits August 25, 2021 23:22
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

Description
This PR integrates vendor specific class objects inside xcvrd for Y-Cable API's to be called.
Detailed designed document can be found sonic-net/SONiC#757

Motivation and Context
Basically xcvrd now has an interface for Y-Cable to interact with PMON docker and HOST
which can be uniform across all vendors. As part of this refactor, we will be moving towards a model where only xcvrd interacts with the cables/transceivers, and host-side processes will communicate with xcvrd rather than with the devices directly with Y-Cable.

How Has This Been Tested?
Ran the changes on Arista7050cx3 switch, making changes inside the container.

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
@vdahiya12 vdahiya12 merged commit b10c417 into sonic-net:202012 Aug 26, 2021
@vdahiya12 vdahiya12 deleted the xcvrd_new_changes branch September 3, 2021 02:39
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
Description
This PR added y-cable driver for simulated mux. This y-cable driver conforms with the requirement of https://github.com/Azure/SONiC/pull/757/files

Motivation and Context
After the abstract y-cable base class is added for multi-vendor y-cable support, we also need a y-cable driver for simulated mux used in lab testing.

How Has This Been Tested?
Update the xcvrd package in pmon docker to include the changes in [xcvrd] initial support for integrating vendor specfic class objects for calling Y-Cable API's inside xcvrd sonic-platform-daemons#197
Update the sonic_y_cable package in pmon docker to include the changes in this PR.
Create /etc/sonic/config_db.json on DUT.
Restart the pmon docker.
Run some dualtor test scripts.
Check mux status on dualtor testbed.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants