-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for port prefix regex #252
base: master
Are you sure you want to change the base?
Added support for port prefix regex #252
Conversation
This PR depends on sonic-net/sonic-swss-common#598 so it will not pass until it merged |
@itamar-talmon unit tests are failing |
82ebbf2
to
a984fe1
Compare
@kcudnik @qiluo-msft - could you please check it out after my update? |
Quoting @lguohan here:- the overall motivation is not quite clear. can you describe what are you trying to achieve here? here is the sonic port naming convention. for new port names convention to be introduced, we need to make a proposal first here. https://github.com/sonic-net/SONiC/blob/master/doc/sonic-port-name.md |
78f9dbe
a984fe1
to
78f9dbe
Compare
What I did
Removed the dependency on the "Ethernet" string in the SONiC code base and added support
for extending the front panel port name pattern.
How I did it
Introduced FRONT_PANEL_PORT_PREFIX_REGEX that extends the old FRONT_PANEL_PORT_PREFIX ("Ethernet")
Updated all the relevant usage of the "Ethernet" throughout the code base to use the new regex pattern
How to verify it
Pass all UT and CI testing.
Why I did it
In order to support distinguishing between different types of front panel ports in a maintainable fashion.
Specifically, we are planning to bring up a system with 'service' ports (in addition to the regular ethernet data ports) - these
are lower speed ports that used for connection to accelerators, internal loopbacks and more.
- Related Commits and Merge Strategy
This is part of a group of related commits and should be merged after sonic-net/sonic-swss-common#598 and sonic-net/sonic-buildimage#10471 and sonic-net/sonic-py-swsssdk#121.
The full merge order is:
https://github.com/Azure/sonic-utilities/pull/2127
https://github.com/Azure/sonic-snmpagent/pull/251
https://github.com/Azure/sonic-swss/pull/2223
https://github.com/Azure/sonic-platform-daemons/pull/252
https://github.com/Azure/sonic-platform-common/pull/274