Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the peer forwarding state table #281

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Aug 10, 2022

Description

Fixes: sonic-net/sonic-linkmgrd#101

ycabled failed to toggle peer forwarding state for active-active ports.
Use ConsumerStateTable to listen to HW_FORWARDING_STATE_PEER.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

Motivation and Context

As the description

How Has This Been Tested?

On a dualtor-mixed testbed, shutdown a port on upper ToR, verified the lower ToR could toggle the nic_simulator upper ToR forwarding state to standby.

Additional Information (Optional)

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@lolyu
Copy link
Contributor Author

lolyu commented Aug 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit c7b7543 into sonic-net:master Aug 10, 2022
yxieca pushed a commit that referenced this pull request Aug 10, 2022
Description
Fixes: sonic-net/sonic-linkmgrd#101

ycabled failed to toggle peer forwarding state for active-active ports.
Use ConsumerStateTable to listen to HW_FORWARDING_STATE_PEER.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

Motivation and Context
As the description

How Has This Been Tested?
On a dualtor-mixed testbed, shutdown a port on upper ToR, verified the lower ToR could toggle the nic_simulator upper ToR forwarding state to standby.

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 29, 2022
Update sonic-platform-daemons submodule pointer to include the following:
* [ycabled] enable telemetry for 'active-active'; fix gRPC portid ordering ([sonic-net#284](sonic-net/sonic-platform-daemons#284))
* [ycabled] remove some spurious logs ([sonic-net#282](sonic-net/sonic-platform-daemons#282))
* Correct the peer forwarding state table ([sonic-net#281](sonic-net/sonic-platform-daemons#281))
* add psu input voltage and current ([sonic-net#276](sonic-net/sonic-platform-daemons#276))
* [ycabled] add capability to enable/disable telemetry ([sonic-net#279](sonic-net/sonic-platform-daemons#279))

Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[active-active] Wrong table name used for toggling PEER's forwarding state
3 participants