[ycable] cleanup logic for creating grpc future ready #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 2 alerts when merging 4229dd6 into 7c0a326 - view on LGTM.com new alerts:
|
yxieca
reviewed
Sep 2, 2022
| target_name = kvp.get("grpc_ssl_credential", None) | ||
| if credential is None or target_name is None: | ||
| return (None, None) | ||
| def create_channel(type,level, kvp, soc_ip, port): |
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 2 alerts when merging 2681dbf into ce3b6db - view on LGTM.com new alerts:
|
lolyu
approved these changes
Sep 7, 2022
yxieca
pushed a commit
that referenced
this pull request
Sep 8, 2022
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com This PR attempts to remove this call channel_ready = grpc.channel_ready_future for the ycabled gRPC implementation. The reason to do this is incase of channel not being connected ycabled tries to reattempt the channel creation again with each RPC request from linkmgrd. This is not the right way to maintain the channels/stubs, and actually adds unrequired overhead for ycabled. This PR supports creating channel/stub in ycabled in correct manner. Description Motivation and Context Required to reduce CPU usage for ycabled How Has This Been Tested? Deploying the changes on Arista testbed and UT
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR attempts to remove this call
channel_ready = grpc.channel_ready_futurefor the ycabled gRPC implementation. The reason to do this is incase of channel not being connected ycabled tries to reattempt the channel creation again with each RPC request from linkmgrd.This is not the right way to maintain the channels/stubs, and actually adds unrequired overhead for ycabled. This PR supports creating channel/stub in ycabled in correct manner.
Description
Motivation and Context
Required to reduce CPU usage for ycabled
How Has This Been Tested?
Deploying the changes on Arista testbed and UT
Additional Information (Optional)