[ycabled] fix naming error when error condition is triggered for ycabled CLI handling #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
zjswhhh
approved these changes
Oct 3, 2022
vdahiya12
changed the title
vdahiya12
changed the title
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 3, 2022
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com This PR fixes a typo/error condition when read_side is not 1 or 2 or -1, for a case where NIC side is plugged into the ToR and a user configures a CLI for sudo config mux hwmode state active/standby <port>, in such a scenario we can trigger this xcvrd_config_hwmode_state_cmd_sts_tbl attribute error. Description Motivation and Context How Has This Been Tested? Unit-tests and loading the changes on Arista testbed
7 tasks
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Feb 9, 2023
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com This PR fixes a typo/error condition when read_side is not 1 or 2 or -1, for a case where NIC side is plugged into the ToR and a user configures a CLI for sudo config mux hwmode state active/standby <port>, in such a scenario we can trigger this xcvrd_config_hwmode_state_cmd_sts_tbl attribute error. Description Motivation and Context How Has This Been Tested? Unit-tests and loading the changes on Arista testbed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
This PR fixes a typo/error condition when read_side is not 1 or 2 or -1, for a case where NIC side is plugged into the ToR and a user configures a CLI for
sudo config mux hwmode state active/standby <port>,in such a scenario we can trigger this
xcvrd_config_hwmode_state_cmd_sts_tbl attribute error.
Description
Motivation and Context
How Has This Been Tested?
Unit-tests and loading the changes on Arista testbed
Additional Information (Optional)