[ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
once Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
prgeor
approved these changes
Oct 7, 2022
prgeor
requested changes
Oct 7, 2022
vdahiya12
changed the title
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 1 alert when merging 3924d75 into 23b6970 - view on LGTM.com new alerts:
|
zjswhhh
previously approved these changes
Oct 12, 2022
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
|
This pull request introduces 2 alerts when merging 7556185 into 4ea12cf - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging ac2888d into 4ea12cf - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 717e599 into 4ea12cf - view on LGTM.com new alerts:
|
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
prgeor
previously approved these changes
Oct 30, 2022
prgeor
approved these changes
Nov 7, 2022
|
#310 added in 202012 |
7 tasks
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Nov 29, 2022
… once per task_worker/thread (#303) This PR attempts for ycabled to have all swsscommon.Table and daemon_base.db_connect as just a single call in the thread instance for all task_workers For example all swsscommon calls to open Tables are moved as class object varables, which are reused when needed instead of opening the Table again in subroutines. self.config_db[asic_id] = daemon_base.db_connect("CONFIG_DB", namespace) This would help in avoiding unforeseen redis-errors Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com Description Motivation and Context How Has This Been Tested? Deploying changes on testbed and UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts for ycabled to have all
swsscommon.Table and daemon_base.db_connectas just a single call in the thread instance for all task_workers
For example all swsscommon calls to open Tables are moved as class object varables, which are reused when needed instead of opening the Table again in subroutines.
This would help in avoiding unforeseen redis-errors
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com
Description
Motivation and Context
How Has This Been Tested?
Deploying changes on testbed and UT
Additional Information (Optional)