-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ycabled] [active-standby] add changes for correcting telemetry values for 'active-standby' when the cable is present but vendor name and part number is not recognized #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for 'active-standby' when the cable is present but vendor name and part number is not recognized Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
prgeor
approved these changes
Apr 29, 2024
@StormLiangMS @yxieca please cherry-pick into the branches tagged |
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
May 9, 2024
…s for 'active-standby' when the cable is present but vendor name and part number is not recognized (sonic-net#478) * [ycabled] [active-standby] add changes for correcting telemetry values for 'active-standby' when the cable is present but vendor name and part number is not recognized Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> * add tests Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> --------- Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Cherry-pick PR to 202305: #486 |
mssonicbld
pushed a commit
that referenced
this pull request
May 9, 2024
…s for 'active-standby' when the cable is present but vendor name and part number is not recognized (#478) * [ycabled] [active-standby] add changes for correcting telemetry values for 'active-standby' when the cable is present but vendor name and part number is not recognized Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> * add tests Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> --------- Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
May 9, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
Aug 28, 2024
…s for 'active-standby' when the cable is present but vendor name and part number is not recognized (sonic-net#478) * [ycabled] [active-standby] add changes for correcting telemetry values for 'active-standby' when the cable is present but vendor name and part number is not recognized Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> * add tests Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> --------- Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Cherry-pick PR to 202311: #536 |
mssonicbld
pushed a commit
that referenced
this pull request
Aug 28, 2024
…s for 'active-standby' when the cable is present but vendor name and part number is not recognized (#478) * [ycabled] [active-standby] add changes for correcting telemetry values for 'active-standby' when the cable is present but vendor name and part number is not recognized Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> * add tests Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com> --------- Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change creates unknown, N/A values for active-standby cable type
Since streaming telemetry today looks for active-standby for posting values to State DB, this change introduces a one time posting of fields with 'pseudo-cable' type when cable port instances are attempted to be created by ycabled.
For almost all cases this was covered except when vendor name and part number does not match to our mapping logic today
This change should cover such an issue
as their will be a one-time post of such values
Motivation and Context
How Has This Been Tested?
UT and posting the changes on test device.
MSFT ADO
27242275
Additional Information (Optional)