Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a call to apply app0 configuration before DP INIT stage #496

Closed
wants to merge 1 commit into from

Conversation

noaOrMlnx
Copy link
Collaborator

depends on: sonic-net/sonic-platform-common#474

Description

When NOS configures the CMIS modules, we need to be aware to a case where some of the lanes are disabled.
According to CMIS spec, in that case, an application 0 is needed to make sure all disabled lanes are zeroed.

Motivation and Context

This was done according to CMIS specification document.

How Has This Been Tested?

This addition to CMIS thread was tested with a CMIS active cable, with only 4 active lanes (and 4 de-active).
We made sure the link is up, right places are zeroed, and have traffic.

Additional Information (Optional)

@noaOrMlnx
Copy link
Collaborator Author

Closing since @prgeor already raised a PR to fix the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants