[chassis][pmon][chassid] Enhance the chassid module on-line or off-line log messages with physical slot number #530
Conversation
…ne with physical slot num Signed-off-by: mlok <marty.lok@nokia.com>
|
@gechiang @judyjoseph This PR enhances the chassis module on-line and off-line message with physical slot info. Please review it. Thanks |
|
@gechiang @judyjoseph I just found this PR #480 have not be merged to 202205 branch while other PRs which are associated with PR #480 have been merged to 202205. Please merge this PRs first. |
@mlok-nokia the PR you quoted is no longer allowed for public 202205 branch for this submodule as it is a feature enhancement and not a bug fix and 202205 release owner stopped accepting changes. We do have internal build that takes it in as a patch already so we are good. |
@gechiang I just made the change and tested it. Please review it again. |
Signed-off-by: mlok <marty.lok@nokia.com>
Ok. Thanks. |
|
@gechiang Do we need this PR for 202205 branch? |
|
can we also have corresponding test for this? |
There are already testcases. But not for checking logging message. |
yes. but we will do it internally as officially public 202205 is closed... So once we have this merged, we will pick it up in our next internal build. For community who also needs this for testing on 202205 MSFT repo will also have to manually patch it in their own internal 202205 based builds... |
|
@kenneth-arista for viz.. |
|
can we add some unit test? |
|
|
All comments seem to have been answered already. Any other comments? @kenneth-arista any comments? |
|
@mlok-nokia a general comment -- there are a few more places in the chassisd script where we just have the Module {} alone, should we add Slot {} there too for uniform logs -- not critical but @gechiang f.y.i |
It seems like there are only two messages which contains Module {}. I will take a look if it is feasible to add the slot for since one of them complains Module {} with hostname while another is logging for CLI command "config chassis module shutdown " |
…ne log messages with physical slot number (sonic-net#530) * [chassis][pmon][chassid] Enhance the chassid module on-line or off-line with physical slot num --------- Signed-off-by: mlok <marty.lok@nokia.com>
|
Cherry-pick PR to 202405: #534 |
…ne log messages with physical slot number (#530) * [chassis][pmon][chassid] Enhance the chassid module on-line or off-line with physical slot num --------- Signed-off-by: mlok <marty.lok@nokia.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Description
Per MSFT request, we enhance the module on-line and off-line messages with physical slot number
Before enhance:
pmon#chassisd: Module LINE-CARD0 is on-line!
pmon#chassisd: Module LINE-CARD0 went off-line!
pmon#chassisd: Module LINE-CARD0 recovered on-line!
pmon#chassisd: Module FABRIC-CARD6 is on-line!
After Enhance:
pmon#chassisd: Module LINE-CARD0 (Slot 1) is on-line!
pmon#chassisd: Module LINE-CARD0 (Slot 1) went off-line!
pmon#chassisd: Module LINE-CARD0 (Slot 1) recovered on-line!
pmon#chassisd: Module FABRIC-CARD6 (Slot 7) is on-line!
This change is required by 202205 branch also.
Motivation and Context
Per MSFT's request -- In order to easily identify a module within a chassis, we need to report the physical slot number whenever we raised “module” related syslogs.
How Has This Been Tested?
Tested with Master branch and 202205 branch.
Additional Information (Optional)