Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202405] [xcvrd] Fix issue: do not print error log when module support non-ethernet application #532

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Junchao-Mellanox
Copy link
Collaborator

Backport #501

Description

In function get_interface_speed, it will log an error if the application name does not contain a valid speed. However, many modules support both ethernet and non-ethernet (e.g. IB) application, non-ethernet application would not contain a valid speed. For such module, the function get_interface_speed logs an error to syslog:

Jun 12 20:09:57.315556 sonic ERR pmon#xcvrd: No interface speed found for: 'IB HDR (Arch.Spec.Vol.2)'

Actually, this is not an error because the module will finally find a proper application via the for loop in function get_cmis_application_desired

Motivation and Context

Remove the unexpected error log since it could be a false alarm. Also, log the module applications if it cannot find a proper application.

How Has This Been Tested?

Manual test

Additional Information (Optional)

@bingwang-ms bingwang-ms merged commit 0a9ff7c into sonic-net:202405 Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants