Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to remove the key of table entry #15

Merged
merged 2 commits into from
Dec 5, 2017

Conversation

liuqu
Copy link

@liuqu liuqu commented Sep 30, 2017

The class ConfigDBConnector has no method to remove the column_key of table entry. To support it, the method "set_entry" is modified to delete the column_key which value is None.

@stcheng stcheng requested a review from taoyl-ms October 1, 2017 00:28
@lguohan lguohan merged commit 993d961 into sonic-net:master Dec 5, 2017
lguohan added a commit that referenced this pull request Dec 5, 2017
lguohan added a commit that referenced this pull request Dec 5, 2017
@lguohan
Copy link
Contributor

lguohan commented Dec 5, 2017

merged #23, we do not explicit del the unwanted fields with the set_entry.

praveen-li pushed a commit to praveen-li/sonic-py-swsssdk that referenced this pull request May 4, 2021
* msft_github/master:
  [configdb]: Addopt get_table method to work with python3. (sonic-net#26)
  [configdb]: add mod_entry, rename set_config to mod_config (sonic-net#25)
  [configdb] fix bug of leaving unwanted columns in a hash (sonic-net#23)
  Revert "Add support to remove the key of table entry (sonic-net#15)" (sonic-net#24)
  Add support to remove the key of table entry (sonic-net#15)
  [configdb] support redis connecting methods other than TCP (sonic-net#22)
  [interface]: Extend the max data wait time to 60s (sonic-net#21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants