Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-revert "read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB" #64

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

jleveque
Copy link
Contributor

Add #51 back in by reverting #57, in because issues should be addressed by the merge of sonic-net/sonic-swss#1124

@jleveque jleveque merged commit ee9ee14 into master Apr 8, 2020
@jleveque jleveque deleted the revert-57-revert-51-master branch April 8, 2020 00:59
@abdosi
Copy link
Contributor

abdosi commented Apr 20, 2020

@jleveque do we need this for 201911 ?

We are not taking this one yet :
add mock tables for LAG_NAME_MAP_TABLE in COUNTERS_DB #114

@jleveque
Copy link
Contributor Author

@abdosi: Good point. It appears we should first cherry-pick sonic-net/sonic-snmpagent#114 into 201911. @qiluo-msft: Can you please confirm?

Also, it appears there are some issues updating the submodule with this commit in master. Let's wait for now.

@qiluo-msft
Copy link
Contributor

@jleveque yes, I marked that PR as 201911 requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants