Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify Vnet GUID for conflicting VNI #99

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

sumukhatv
Copy link
Collaborator

@sumukhatv sumukhatv commented Dec 9, 2021

While creating a new VNET with the same VNI, the API caller might find it useful to know the exiting Vnet GUID for the conflicting VNI. Hence, we are modifying the VNET create API to return the Vnet GUID of the conflicting VNI

Existing response: "Object already exists: 1001"
New response: "Object already exists: {"vni": "1001", "vnet_name": "vnet_guid_1"}

@sumukhatv sumukhatv requested a review from prsunny December 9, 2021 23:06
@prsunny
Copy link
Collaborator

prsunny commented Dec 9, 2021

please also update the description with previous output and new output

@sumukhatv sumukhatv merged commit 94805a3 into sonic-net:master Dec 15, 2021
@sumukhatv sumukhatv deleted the dup_vnid branch December 15, 2021 23:17
sumukhatv added a commit that referenced this pull request Jul 27, 2022
sumukhatv added a commit that referenced this pull request Jul 27, 2022
abdosi added a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 29, 2022
commit 5f7cb77230fceb1b7fd30c57a70d0cd05cd6dd95 (HEAD -> 201911, origin/201911)
Author: Sumukha Tumkur Vani <sumukhatv@outlook.com>
Date:   Wed Jul 27 16:51:38 2022 -0700

    Use 201911/stretch dependencies for build (#118)

commit e3809523050df75ec18bf31a5dc3a2e595d58a14
Author: Sumukha Tumkur Vani <sumukhatv@outlook.com>
Date:   Wed Jul 27 15:17:12 2022 -0700

    Change response message for conflicting VNI (#117)

    Ref: sonic-net/sonic-restapi#99

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants