Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[syncd] Remove error message when tryTranslateVidToRid fails #1048

Merged
merged 2 commits into from
Jul 20, 2022
Merged

[syncd] Remove error message when tryTranslateVidToRid fails #1048

merged 2 commits into from
Jul 20, 2022

Conversation

kcudnik
Copy link
Collaborator

@kcudnik kcudnik commented May 26, 2022

Fixes #1047

@kcudnik kcudnik mentioned this pull request May 26, 2022
Closed
lguohan
lguohan previously approved these changes Jun 13, 2022
View reviewed changes
@kcudnik
Copy link
Collaborator Author

kcudnik commented Jul 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Contributor

Hi @kcudnik
I'm just curious why we still need to retrieve RID from VID when a flex counter is removed as the RID is not really used in the removing flow and we can run into a racing condition that RID is not available anymore.
Just for logging the debug information to notify the user of the fact that we are facing a racing condition or other purposes?
thanks

@kcudnik
Copy link
Collaborator Author

kcudnik commented Jul 20, 2022

yes, race condition can happen when counter is removed and api called at the same time, since those 2 events come in 2 different redis events

@kcudnik kcudnik merged commit f554d34 into sonic-net:master Jul 20, 2022
@kcudnik kcudnik deleted the tryvid branch July 20, 2022 12:51
@stephenxs
Copy link
Contributor

hi @kcudnik can we cherry-pick it to 202205?

yxieca pushed a commit that referenced this pull request Aug 8, 2022
@kcudnik @yxieca
[syncd] Remove error message when tryTranslateVidToRid fails (#1048)
8be9292
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
@kcudnik
[syncd] Remove error message when tryTranslateVidToRid fails (sonic-n…
4224f0a 
…et#1048)
skbarista pushed a commit to skbarista/sonic-sairedis that referenced this pull request Dec 2, 2022
@kcudnik @skbarista
[syncd] Remove error message when tryTranslateVidToRid fails (sonic-n…
139d971 
…et#1048)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan left review comments

Assignees
No one assigned
Labels
Cleanup Included in 202205 Branch Request for 202205 Branch
Projects
None yet
Milestone
No milestone
4 participants
@kcudnik @stephenxs @lguohan @yxieca