Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run 20 vs tests at a time. #1111

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Run 20 vs tests at a time. #1111

merged 1 commit into from
Aug 29, 2022

Conversation

mint570
Copy link
Contributor

@mint570 mint570 commented Aug 23, 2022

In vs test, run 20 tests at a time instead of running all the tests together.
This may help in fixing the test issue.

Change-Id: Ib8c5f26944355b4dafe2dfe64ba1de9a7c6b1b2f
@kcudnik
Copy link
Collaborator

kcudnik commented Aug 23, 2022

In vs test, run 20 tests at a time instead of running all the tests together.
This may help in fixing the test issue.

what test issue? can you be more specific here?

@mint570
Copy link
Contributor Author

mint570 commented Aug 23, 2022

If we run all the tests together, the last few tests will fail. I don't know the exact reason. It might due to out of memory.
The last few tests are always p4rt tests. We saw this failure in #1109.
We recently submitted new development and added more vs tests. So this failure might happen for all PRs.

@kcudnik
Copy link
Collaborator

kcudnik commented Aug 23, 2022

ok

@mint570
Copy link
Contributor Author

mint570 commented Aug 29, 2022

Can we merge this PR now?

@kcudnik kcudnik merged commit da26ace into sonic-net:master Aug 29, 2022
@mint570 mint570 deleted the fix_vs_test branch August 29, 2022 17:48
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Aug 29, 2022
Update sonic-sairedis submodule pointer to include the following:
* Run 20 vs tests at a time. ([sonic-net#1111](sonic-net/sonic-sairedis#1111))
* [asan] suppress the static variable leaks ([sonic-net#1085](sonic-net/sonic-sairedis#1085))
* [sonic-sairedis] Support bulk counter ([sonic-net#1094](sonic-net/sonic-sairedis#1094))
* Transfer organization from Azure to sonic-net ([sonic-net#1095](sonic-net/sonic-sairedis#1095))
* [BFN] Provide unified approach to select P4 profile based on chip family ([sonic-net#1089](sonic-net/sonic-sairedis#1089))

Signed-off-by: dprital <drorp@nvidia.com>
mlorrillere added a commit to mlorrillere/sonic-buildimage that referenced this pull request Sep 8, 2022
* 660a920 [Chassis] Create fabric ports for switch_type fabric. (sonic-net/sonic-sairedis#1114)
* 8140c22 Fix issue: bulk counter feature cannot compile on platforms having no sai_bulk_object_get_stats/sai_bulk_object_clear_stats (sonic-net/sonic-sairedis#1105)
* 0aa60f5 [lgtm] Add uuid library (sonic-net/sonic-sairedis#1119)
* e8a01a8 Add retry on zmq functions if fail with EINTR. (sonic-net/sonic-sairedis#1109)
* 594b242 Add SAI_PORT_ATTR_OPER_SPEED support (sonic-net/sonic-sairedis#1107)
* 4c9e048 Add Xsight specific syncd start options (sonic-net/sonic-sairedis#1112)
* da26ace Run 20 vs tests at a time. (sonic-net/sonic-sairedis#1111)
* ffc4109 [asan] suppress the static variable leaks (sonic-net/sonic-sairedis#1085)
* bfd37e3 [sonic-sairedis] Support bulk counter (sonic-net/sonic-sairedis#1094)
* 90ba09a Transfer organization from Azure to sonic-net (sonic-net/sonic-sairedis#1095)
* 4853881 [BFN] Provide unified approach to select P4 profile based on chip family (sonic-net/sonic-sairedis#1089)
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
In vs test, run 20 tests at a time instead of running all the tests together.
This may help in fixing the test issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants