Make changes to building and packaging sairedis #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the following changes: 1. Use Debian build profiles instead of custom build targets to build different configurations of sairedis. Build profiles were designed for this purpose. This also makes the debian/rules file a bit cleaner. 2. Rely on the debug packages being automatically created, instead of us explicitly specifying it in debian/control. 3. Add actual support for excluding Python 2 binding build. 4. Make sure the compile flags used for building Python 2 and Python 3 are actually correct. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
force-pushed
the
build-packaging-changes
branch
from
62f6309
to
90c59f7
Compare
kcudnik
reviewed
Oct 24, 2022
Comment on lines
+4
to
+5
| usr/lib/*/libsaimetadata.so | ||
| usr/lib/*/libsaimeta.so |
There was a problem hiding this comment.
should those be in non-dev package?
There was a problem hiding this comment.
No, these files are only needed at linking time, not during runtime. At linking time, the SONAME of these libraries (which, I believe, are libsaimetadata.so.0.0.0 and libsaimeta.so.0.0.0 for these two libraries) gets recorded in the binary/library, and that file instead gets loaded.
kcudnik
approved these changes
Oct 24, 2022
|
@saiarcot895 , sonic-swss-common validation break because debian/rules remove 'binary-syncd-vs' in this PR: https://github.com/sonic-net/sonic-swss-common/blob/master/.azure-pipelines/build-sairedis-template.yml dpkg-buildpackage: info: host architecture amd64 |
saiarcot895
added a commit
to saiarcot895/sonic-swss-common
that referenced
this pull request
Oct 26, 2022
The build rules for sairedis have been simplified in sonic-net/sonic-sairedis#1116. As a result, build targets have changed. Update the build step here accordingly. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
to saiarcot895/sonic-sairedis
that referenced
this pull request
Oct 27, 2022
…)" This may be causing or exposing some issues during tests. This reverts commit 7b39fc4.
7 tasks
saiarcot895
added a commit
that referenced
this pull request
Oct 27, 2022
richardyu-ms
pushed a commit
to richardyu-ms/sonic-sairedis
that referenced
this pull request
Nov 15, 2022
* Make changes to building and packaging sairedis This commit includes the following changes: 1. Use Debian build profiles instead of custom build targets to build different configurations of sairedis. Build profiles were designed for this purpose. This also makes the debian/rules file a bit cleaner. 2. Rely on the debug packages being automatically created, instead of us explicitly specifying it in debian/control. 3. Add actual support for excluding Python 2 binding build. 4. Make sure the compile flags used for building Python 2 and Python 3 are actually correct. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Update pipeline file Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix argument for profile Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Exclude libsai package from the list of dependencies Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Allow multiple syslog artifacts during tests Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
richardyu-ms
pushed a commit
to richardyu-ms/sonic-sairedis
that referenced
this pull request
Nov 15, 2022
…)" (sonic-net#1141) This may be causing or exposing some issues during tests. This reverts commit 7b39fc4.
richardyu-ms
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Make changes to building and packaging sairedis This commit includes the following changes: 1. Use Debian build profiles instead of custom build targets to build different configurations of sairedis. Build profiles were designed for this purpose. This also makes the debian/rules file a bit cleaner. 2. Rely on the debug packages being automatically created, instead of us explicitly specifying it in debian/control. 3. Add actual support for excluding Python 2 binding build. 4. Make sure the compile flags used for building Python 2 and Python 3 are actually correct. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Update pipeline file Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix argument for profile Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Exclude libsai package from the list of dependencies Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Allow multiple syslog artifacts during tests Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
richardyu-ms
pushed a commit
that referenced
this pull request
Nov 16, 2022
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* Make changes to building and packaging sairedis This commit includes the following changes: 1. Use Debian build profiles instead of custom build targets to build different configurations of sairedis. Build profiles were designed for this purpose. This also makes the debian/rules file a bit cleaner. 2. Rely on the debug packages being automatically created, instead of us explicitly specifying it in debian/control. 3. Add actual support for excluding Python 2 binding build. 4. Make sure the compile flags used for building Python 2 and Python 3 are actually correct. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Update pipeline file Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix argument for profile Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Exclude libsai package from the list of dependencies Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Allow multiple syslog artifacts during tests Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
…)" (sonic-net#1141) This may be causing or exposing some issues during tests. This reverts commit 7b39fc4.
saiarcot895
added a commit
to saiarcot895/sonic-sairedis
that referenced
this pull request
Jan 5, 2023
…)' * Make changes to building and packaging sairedis This commit includes the following changes: 1. Use Debian build profiles instead of custom build targets to build different configurations of sairedis. Build profiles were designed for this purpose. This also makes the debian/rules file a bit cleaner. 2. Rely on the debug packages being automatically created, instead of us explicitly specifying it in debian/control. 3. Add actual support for excluding Python 2 binding during build. 4. Make sure the compile flags used for building Python 2 and Python 3 are actually correct. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Update pipeline file Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix argument for profile Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Exclude libsai package from the list of dependencies Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Allow multiple syslog artifacts during tests Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
added a commit
that referenced
this pull request
Jun 30, 2023
* Reland 'Make changes to building and packaging sairedis (#1116)' * Make changes to building and packaging sairedis This commit includes the following changes: 1. Use Debian build profiles instead of custom build targets to build different configurations of sairedis. Build profiles were designed for this purpose. This also makes the debian/rules file a bit cleaner. 2. Rely on the debug packages being automatically created, instead of us explicitly specifying it in debian/control. 3. Add actual support for excluding Python 2 binding during build. 4. Make sure the compile flags used for building Python 2 and Python 3 are actually correct. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Update pipeline file Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix argument for profile Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Exclude libsai package from the list of dependencies Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Allow multiple syslog artifacts during tests Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix debug poackage name in dockerfile Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> * Fix armhf build due to python binary not existing Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com> --------- Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
different configurations of sairedis. Build profiles were designed for
this purpose. This also makes the debian/rules file a bit cleaner.
explicitly specifying it in debian/control.
are actually correct.