[hash]: Extend VS lib with ECMP/LAG hash #1192

nazariig · 2023-01-04T12:53:20Z

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

HLD: sonic-net/SONiC#1101

DEPENDS:

[hash]: Add UT infra sonic-swss#2660

nazariig · 2023-01-05T17:04:10Z

@liat-grozovik / @volodymyrsamotiy FYI

nazariig · 2023-01-05T17:06:45Z

/azpw run

mssonicbld · 2023-01-05T17:06:46Z

/AzurePipelines run

azure-pipelines · 2023-01-05T17:06:58Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2023-02-07T14:23:45Z

/azp run Azure.sonic-sairedis

azure-pipelines · 2023-02-07T14:23:50Z

Commenter does not have sufficient privileges for PR 1192 in repo sonic-net/sonic-sairedis

saiarcot895 · 2023-02-07T21:24:22Z

/azpw run

saiarcot895 · 2023-02-07T21:29:02Z

/AzurePipelines run

azure-pipelines · 2023-02-07T21:29:13Z

Azure Pipelines successfully started running 1 pipeline(s).

saiarcot895 · 2023-02-08T01:51:09Z

I see a number of test failures in vstest (same failures in both the ASAN and non-ASAN build). I've requested a rerun, but suspect that these are actual failures rather than transient failures. Can you take a look at these?

Snippet of errors:

test_PbhHashCreationDeletion failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:170>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]
test_PbhHashCreationDeletion failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:170>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]
test_PbhTableCreationDeletion passed 1 out of the required 1 times. Success!
test_PbhRuleCreationDeletion failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:250>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]
test_PbhRuleCreationDeletion failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:250>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]
test_PbhRuleUpdate failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:355>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]

nazariig · 2023-02-08T07:06:44Z

I see a number of test failures in vstest (same failures in both the ASAN and non-ASAN build). I've requested a rerun, but suspect that these are actual failures rather than transient failures. Can you take a look at these?

Snippet of errors:

test_PbhHashCreationDeletion failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:170>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]
test_PbhHashCreationDeletion failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:170>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]
test_PbhTableCreationDeletion passed 1 out of the required 1 times. Success!
test_PbhRuleCreationDeletion failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:250>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]
test_PbhRuleCreationDeletion failed; it passed 0 out of the required 1 times.
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:250>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]
test_PbhRuleUpdate failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=0, received=2 (('oid:0x1c000000000565', 'oid:0x1c000000000566')), table="ASIC_STATE:SAI_OBJECT_TYPE_HASH"
	[<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_pbh.py:355>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_pbh.py:118>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:395>]

@saiarcot895 you are right. PBH SWSS tests need to be aligned. It was done in another PR.

nazariig · 2023-02-08T18:36:16Z

/azpw run

mssonicbld · 2023-02-08T18:36:18Z

/AzurePipelines run

azure-pipelines · 2023-02-08T18:36:28Z

Azure Pipelines successfully started running 1 pipeline(s).

saiarcot895 · 2023-02-09T01:56:55Z

Can the PR coverage be bumped up above 80%? Looks like adding a couple of error cases (specifically, SAI_STATUS_BUFFER_OVERFLOW) should cover it.

nazariig · 2023-02-09T08:30:20Z

Can the PR coverage be bumped up above 80%? Looks like adding a couple of error cases (specifically, SAI_STATUS_BUFFER_OVERFLOW) should cover it.

@saiarcot895 sure. Will take care.

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

nazariig · 2023-02-10T22:43:31Z

@saiarcot895 code coverage issue has been fixed

nazariig · 2023-02-13T08:36:17Z

@saiarcot895 can you please help to review & merge?

nazariig mentioned this pull request Jan 4, 2023

Generic Hash HLD sonic-net/SONiC#1101

Merged

nazariig force-pushed the master-hash-rel branch from 6742baa to f8da0c3 Compare January 4, 2023 13:52

nazariig mentioned this pull request Jan 4, 2023

[hash]: Implement GH backend sonic-net/sonic-swss#2598

Merged

nazariig force-pushed the master-hash-rel branch 4 times, most recently from 7a743ac to 4186bb3 Compare January 5, 2023 17:01

nazariig requested review from kcudnik, liat-grozovik and volodymyrsamotiy January 16, 2023 19:20

nazariig requested a review from saiarcot895 February 9, 2023 08:31

nazariig added 2 commits February 10, 2023 19:39

[hash]: Extend VS lib with ECMP/LAG hash.

7a1feae

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

[hash]: Handle review comments.

d361767

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

nazariig force-pushed the master-hash-rel branch from 4186bb3 to d361767 Compare February 10, 2023 17:42

saiarcot895 approved these changes Feb 13, 2023

View reviewed changes

saiarcot895 merged commit 4d86af3 into sonic-net:master Feb 13, 2023

nazariig added the Request for 202305 Branch label Jul 10, 2023

StormLiangMS added the Included in 202305 Branch label Jul 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[hash]: Extend VS lib with ECMP/LAG hash #1192

[hash]: Extend VS lib with ECMP/LAG hash #1192

nazariig commented Jan 4, 2023 •

edited

Loading

nazariig commented Jan 5, 2023

nazariig commented Jan 5, 2023

mssonicbld commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

liat-grozovik commented Feb 7, 2023

azure-pipelines bot commented Feb 7, 2023

saiarcot895 commented Feb 7, 2023

saiarcot895 commented Feb 7, 2023

azure-pipelines bot commented Feb 7, 2023

saiarcot895 commented Feb 8, 2023

nazariig commented Feb 8, 2023

nazariig commented Feb 8, 2023

mssonicbld commented Feb 8, 2023

azure-pipelines bot commented Feb 8, 2023

saiarcot895 commented Feb 9, 2023

nazariig commented Feb 9, 2023

nazariig commented Feb 10, 2023

nazariig commented Feb 13, 2023

[hash]: Extend VS lib with ECMP/LAG hash #1192

[hash]: Extend VS lib with ECMP/LAG hash #1192

Conversation

nazariig commented Jan 4, 2023 • edited Loading

nazariig commented Jan 5, 2023

nazariig commented Jan 5, 2023

mssonicbld commented Jan 5, 2023

azure-pipelines bot commented Jan 5, 2023

liat-grozovik commented Feb 7, 2023

azure-pipelines bot commented Feb 7, 2023

saiarcot895 commented Feb 7, 2023

saiarcot895 commented Feb 7, 2023

azure-pipelines bot commented Feb 7, 2023

saiarcot895 commented Feb 8, 2023

nazariig commented Feb 8, 2023

nazariig commented Feb 8, 2023

mssonicbld commented Feb 8, 2023

azure-pipelines bot commented Feb 8, 2023

saiarcot895 commented Feb 9, 2023

nazariig commented Feb 9, 2023

nazariig commented Feb 10, 2023

nazariig commented Feb 13, 2023

nazariig commented Jan 4, 2023 •

edited

Loading