[syncd]: Enable port bulk API #1197

nazariig · 2023-01-23T19:17:03Z

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

HLD: sonic-net/SONiC#1084

Summary:

Port bulk API support for syncd
New test infrastructure for syncd
New test infrastructure for VendorSai
GCOVR parser hotfix: rollback to stable v5.0

nazariig · 2023-01-27T13:09:35Z

/azpw run

mssonicbld · 2023-01-27T13:09:37Z

/AzurePipelines run

azure-pipelines · 2023-01-27T13:09:47Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-01-27T14:29:14Z

PR fails due to GCOVR errors:

+ gcovr --version
gcovr 5.2

Copyright (c) 2013-2022 the gcovr authors
Copyright (c) 2013 Sandia Corporation.
Under the terms of Contract DE-AC04-94AL85000 with Sandia Corporation,
the U.S. Government retains certain rights in this software.
+ find SAI/meta -name '*.gc*'
+ xargs rm -vf
removed 'SAI/meta/libsaimetadata_la-saimetadata.gcno'
removed 'SAI/meta/libsaimetadata_la-saimetadatautils.gcno'
removed 'SAI/meta/.libs/libsaimetadata_la-saimetadata.gcno'
removed 'SAI/meta/.libs/libsaimetadata_la-saimetadatautils.gcno'
removed 'SAI/meta/.libs/libsaimetadata_la-saimetadatautils.gcda'
removed 'SAI/meta/.libs/libsaimetadata_la-saimetadata.gcda'
removed 'SAI/meta/.libs/libsaimetadata_la-saiserialize.gcno'
removed 'SAI/meta/.libs/libsaimetadata_la-saiserialize.gcda'
removed 'SAI/meta/libsaimetadata_la-saiserialize.gcno'
+ gcovr -r ./ -e '.*/SAI/.*' -e .+/json.hpp -e swss/.+ -e '.*/.libs/.*' -e '.*/debian/.*' --exclude-unreachable-branches --exclude-throw-branches -x --xml-pretty -o coverage.xml
(WARNING) Unrecognized GCOV output for /__w/1/s/meta/SaiSerialize.cpp
	  function sai_serialize_object_id[abi:cxx11](unsigned long) called 7486270 returned NAN % blocks executed 62%
	This is indicative of a gcov output parse error.
	Please report this to the gcovr developers
	at <[https://github.com/gcovr/gcovr/issues>.](https://github.com/gcovr/gcovr/issues%3E.)
(WARNING) Exception during parsing:
	UnknownLineType: function sai_serialize_object_id[abi:cxx11](unsigned long) called 7486270 returned NAN % blocks executed 62%
(ERROR) Exiting because of parse errors.
	You can run gcovr with --gcov-ignore-parse-errors
	to continue anyway.
(ERROR) Trouble processing '/__w/1/s/meta/.libs/libsaimeta_la-SaiSerialize.gcda' with working directory '/__w/1/s/meta'.
Stdout of gcov was >>File 'SaiSerialize.cpp'
Lines executed:94.24% of 2100
Branches executed:93.37% of 3589
Taken at least once:53.39% of 3589
Calls executed:73.83% of 3076
Creating 'SaiSerialize.cpp##74fbe304ca213391ad9d6de89ec6b791.gcov'

This is a known bug: gcovr/gcovr#708
According to the GCOVR maintainers, it will be fixed as part of the upcoming release.

Committing a rollback to GCOV v5.0 as a W/A.

nazariig · 2023-01-27T19:27:10Z

/azpw run

mssonicbld · 2023-01-27T19:27:11Z

/AzurePipelines run

azure-pipelines · 2023-01-27T19:27:24Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-01-27T20:53:10Z

/azpw run

mssonicbld · 2023-01-27T20:53:11Z

/AzurePipelines run

azure-pipelines · 2023-01-27T20:53:23Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-01-29T21:39:28Z

@kcudnik / @saiarcot895 would you please have a look?

nazariig · 2023-01-31T22:08:53Z

@kcudnik / @saiarcot895 just a kind reminder

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

nazariig · 2023-02-02T16:08:01Z

/azpw run

mssonicbld · 2023-02-02T16:08:03Z

/AzurePipelines run

azure-pipelines · 2023-02-02T16:08:16Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-02-06T19:22:58Z

/azpw run

mssonicbld · 2023-02-06T19:22:59Z

/AzurePipelines run

azure-pipelines · 2023-02-06T19:23:10Z

Azure Pipelines successfully started running 1 pipeline(s).

syncd/tests.cpp

nazariig · 2023-02-06T22:35:26Z

/azpw run

mssonicbld · 2023-02-06T22:35:28Z

/AzurePipelines run

azure-pipelines · 2023-02-06T22:35:38Z

Azure Pipelines successfully started running 1 pipeline(s).

nazariig · 2023-02-07T13:31:16Z

@saiarcot895 can you please help to merge this PR?

The path to the sairedis test binary (for `setcap`) has changed after sonic-net/sonic-sairedis#1197. Update the path here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

* [syncd]: Enable port bulk API. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [syncd]: Add UT infra. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [gcovr]: Temporarily disable parse errors. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> * [gcovr]: Rollback to gcovr v5.0. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com> --------- Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

kcudnik · 2023-03-09T18:34:17Z

unittest/syncd/TestVendorSai.cpp

+public:
+    virtual void SetUp() override
+    {
+        m_vsai = std::make_shared<VendorSai>();


this is not required in setup, this init and teardown should be in the test itself

@kcudnik having the same instruction in each test will lead to code duplication. The whole idea of using this fixture is to minimize amount of the identical code and let the user to focus on API testing. Also, here we want to force a cleanup when the test fails unexpectedly. Please elaborate on why it is a wrong approach?

The path to the sairedis test binary (for `setcap`) has changed after sonic-net/sonic-sairedis#1197. Update the path here. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>

nazariig mentioned this pull request Jan 23, 2023

[ppi]: Implement port bulk comparison logic sonic-net/sonic-swss#2564

Merged

nazariig requested a review from kcudnik January 23, 2023 19:20

nazariig force-pushed the master-bulk-api branch 2 times, most recently from 0d4a45c to 4843cdf Compare January 27, 2023 12:34

nazariig marked this pull request as ready for review January 27, 2023 13:27

nazariig requested review from liat-grozovik, volodymyrsamotiy and saiarcot895 January 27, 2023 15:12

nazariig added 4 commits February 2, 2023 15:14

[syncd]: Enable port bulk API.

056827b

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

[syncd]: Add UT infra.

ded433c

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

[gcovr]: Temporarily disable parse errors.

6a20756

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

[gcovr]: Rollback to gcovr v5.0.

7ef57d5

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>

nazariig force-pushed the master-bulk-api branch from 0cbbeaa to 7ef57d5 Compare February 2, 2023 13:22

saiarcot895 reviewed Feb 6, 2023

View reviewed changes

syncd/tests.cpp Show resolved Hide resolved

saiarcot895 approved these changes Feb 6, 2023

View reviewed changes

volodymyrsamotiy approved these changes Feb 7, 2023

View reviewed changes

saiarcot895 merged commit a2c37b8 into sonic-net:master Feb 7, 2023

saiarcot895 mentioned this pull request Feb 8, 2023

[CI] Update path to sairedis tests sonic-net/sonic-swss-common#747

Merged

nazariig added the Request for 202211 Branch label Feb 22, 2023

StormLiangMS added the Included in 202211 Branch label Mar 7, 2023

kcudnik reviewed Mar 9, 2023

View reviewed changes

nazariig mentioned this pull request Jun 14, 2023

[202211][ppi]: Implement port bulk comparison logic (#2564) sonic-net/sonic-swss#2821

Merged

nazariig added the Request for 202305 Branch label Jul 4, 2023

StormLiangMS added the Included in 202305 Branch label Jul 19, 2023

nazariig mentioned this pull request Oct 6, 2023

[202305][ppi]: Implement port bulk comparison logic sonic-net/sonic-swss#2921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[syncd]: Enable port bulk API #1197

[syncd]: Enable port bulk API #1197

nazariig commented Jan 23, 2023 •

edited

Loading

nazariig commented Jan 27, 2023

mssonicbld commented Jan 27, 2023

azure-pipelines bot commented Jan 27, 2023

nazariig commented Jan 27, 2023 •

edited

Loading

nazariig commented Jan 27, 2023

mssonicbld commented Jan 27, 2023

azure-pipelines bot commented Jan 27, 2023

nazariig commented Jan 27, 2023

mssonicbld commented Jan 27, 2023

azure-pipelines bot commented Jan 27, 2023

nazariig commented Jan 29, 2023

nazariig commented Jan 31, 2023

nazariig commented Feb 2, 2023

mssonicbld commented Feb 2, 2023

azure-pipelines bot commented Feb 2, 2023

nazariig commented Feb 6, 2023

mssonicbld commented Feb 6, 2023

azure-pipelines bot commented Feb 6, 2023

nazariig commented Feb 6, 2023

mssonicbld commented Feb 6, 2023

azure-pipelines bot commented Feb 6, 2023

nazariig commented Feb 7, 2023

kcudnik Mar 9, 2023

nazariig Mar 12, 2023

[syncd]: Enable port bulk API #1197

[syncd]: Enable port bulk API #1197

Conversation

nazariig commented Jan 23, 2023 • edited Loading

nazariig commented Jan 27, 2023

mssonicbld commented Jan 27, 2023

azure-pipelines bot commented Jan 27, 2023

nazariig commented Jan 27, 2023 • edited Loading

nazariig commented Jan 27, 2023

mssonicbld commented Jan 27, 2023

azure-pipelines bot commented Jan 27, 2023

nazariig commented Jan 27, 2023

mssonicbld commented Jan 27, 2023

azure-pipelines bot commented Jan 27, 2023

nazariig commented Jan 29, 2023

nazariig commented Jan 31, 2023

nazariig commented Feb 2, 2023

mssonicbld commented Feb 2, 2023

azure-pipelines bot commented Feb 2, 2023

nazariig commented Feb 6, 2023

mssonicbld commented Feb 6, 2023

azure-pipelines bot commented Feb 6, 2023

nazariig commented Feb 6, 2023

mssonicbld commented Feb 6, 2023

azure-pipelines bot commented Feb 6, 2023

nazariig commented Feb 7, 2023

kcudnik Mar 9, 2023

Choose a reason for hiding this comment

nazariig Mar 12, 2023

Choose a reason for hiding this comment

nazariig commented Jan 23, 2023 •

edited

Loading

nazariig commented Jan 27, 2023 •

edited

Loading