Fixing race condition for rif counters #1136 (202205 branch) #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumanbrcm
changed the title
|
@prsunny , @Junchao-Mellanox , @kcudnik , @dgsudharsan Please note that the cherry pick in 202205 branch failed for (#1136) , so this PR was needed. All the details are mentioned in this PR. |
|
@sumanbrcm can you help look into the test failure? |
sumanbrcm
force-pushed
the
rif_counter_cleanup_202205
branch
from
54bf9e7
to
090a376
Compare
Changes for 202205 branch Signed-off-by: Suman Kumar <suman.kumar@broadcom.com>
sumanbrcm
force-pushed
the
rif_counter_cleanup_202205
branch
from
090a376
to
979b623
Compare
Junchao-Mellanox
approved these changes
Feb 7, 2023
|
/azpw run Azure.sonic-sairedis |
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 1202 in repo sonic-net/sonic-sairedis |
|
/azpw run Azure.sonic-sairedis |
|
/AzurePipelines run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for 202205 branch
sairedis: Fixing race condition for rif counters #1136
swss: Fixing race condition for rif counters sonic-swss#2488
Unit Tests:-
The steps followed are same as in sonic-net/sonic-buildimage#11621
After RIF creation derived info of oid for RIF from "COUNTERS_RIF_NAME_MAP"
127) "Vlan100"
128) "oid:0x6000000000aa5"
Checked all the tabled in COUNTER_DB which has same OID in keys
127.0.0.1:6379[2]> keys 6000000000aa5
127.0.0.1:6379[2]>
Deleted the RIF by removing the ip on the intf.
Checked COUNTER_DB again with same OID if there are stale entries or not. No stale entries exist now.
127.0.0.1:6379[2]> keys 6000000000aa5
(empty array)
127.0.0.1:6379[2]>
Signed-off-by: Suman Kumar suman.kumar@broadcom.com