Ignore removing switch for mellanox platform due to known limitation #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazariig
approved these changes
Mar 7, 2023
liat-grozovik
approved these changes
Mar 7, 2023
|
Hi @kcudnik , could you please kindly review this? |
|
@kcudnik @saiarcot895 can you please review and merge? |
kcudnik
approved these changes
Mar 9, 2023
yxieca
pushed a commit
that referenced
this pull request
Mar 15, 2023
…1216) * Ignore removing switch for mellanox platform due to known limitation * Fix review comment * Fix review comment
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 19, 2023
…1216) * Ignore removing switch for mellanox platform due to known limitation * Fix review comment * Fix review comment
8 tasks
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-sairedis
that referenced
this pull request
Apr 24, 2023
…itation (sonic-net#1216)" This reverts commit acd57ae.
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-sairedis
that referenced
this pull request
Apr 24, 2023
…itation (sonic-net#1216)" This reverts commit 62aa244.
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-sairedis
that referenced
this pull request
Apr 24, 2023
…itation (sonic-net#1216)" This reverts commit 10f37ef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did this?
Due to a limitation in mellanox platform, sonic ignores syncs graceful shutdown in syncd.sh previously. However, ignoring graceful shutdown in syncd.sh also ignores closing other resources such as removing all counters.
This PR is going to ignore remove_switch for mellanox platform when shutdown type is cold. It make sure other shutdown operations are properly executed in shutdown flow.
How I test this?
Running config reload on many platforms and check result.