Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202405][fastboot] Notify SAI that fastboot is done #1468

Merged

Conversation

Junchao-Mellanox
Copy link
Contributor

Backport #1396 to 202405

Why I did this

Notify SAI that fastboot is done

How I did this

Set SAI_SWITCH_ATTR_FAST_API_ENABLE to false when fastboot is done

How I verify this

Manual test

Notify SAI that fastboot is done
Set SAI_SWITCH_ATTR_FAST_API_ENABLE to false when fastboot is done
@bingwang-ms bingwang-ms merged commit 497bd05 into sonic-net:202405 Dec 2, 2024
17 checks passed
@bingwang-ms
Copy link
Contributor

bingwang-ms commented Dec 9, 2024

@Junchao-Mellanox This PR caused failure in PR test in submodule update. sonic-net/sonic-buildimage#21001
The error message points to the code changed in this PR. Can you take a look?

TestSyncd.cpp:16:23: error: 'empty' is not a type
     MOCK_METHOD(bool, empty, (), (override));
                       ^~~~~
TestSyncd.cpp:16:30: error: expected identifier before '(' token
     MOCK_METHOD(bool, empty, (), (override));
                              ^
TestSyncd.cpp:16:34: error: expected identifier before '(' token
     MOCK_METHOD(bool, empty, (), (override));
                                  ^
TestSyncd.cpp:16:44: error: ISO C++ forbids declaration of 'MOCK_METHOD' with no type [-fpermissive]
     MOCK_METHOD(bool, empty, (), (override));
                                            ^
TestSyncd.cpp:17:23: error: 'pop' is not a type
     MOCK_METHOD(void, pop, (swss::KeyOpFieldsValuesTuple& kco, bool initViewMode), (override));
                       ^~~
TestSyncd.cpp:17:28: error: expected identifier before '(' token
     MOCK_METHOD(void, pop, (swss::KeyOpFieldsValuesTuple& kco, bool initViewMode), (override));
                            ^
TestSyncd.cpp:17:84: error: expected identifier before '(' token
     MOCK_METHOD(void, pop, (swss::KeyOpFieldsValuesTuple& kco, bool initViewMode), (override));
                                                                                    ^
TestSyncd.cpp:17:94: error: ISO C++ forbids declaration of 'MOCK_METHOD' with no type [-fpermissive]
     MOCK_METHOD(void, pop, (swss::KeyOpFieldsValuesTuple& kco, bool initViewMode), (override));
                                                                                              ^
TestSyncd.cpp:17:17: error: invalid use of type 'void' in parameter declaration
     MOCK_METHOD(void, pop, (swss::KeyOpFieldsValuesTuple& kco, bool initViewMode), (override));
                 ^~~~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants