ICMP_ECHO_SESSION meta and notification layer changes #1542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
Feb 27, 2025
| @@ -36,6 +36,7 @@ libsaimeta_la_SOURCES = \ | |||
| NotificationSwitchShutdownRequest.cpp \ | |||
| NotificationSwitchStateChange.cpp \ | |||
| NotificationBfdSessionStateChange.cpp \ | |||
| NotificationIcmpEchoSessionStateChange.cpp \ | |||
kcudnik
requested changes
Feb 27, 2025
|
|
||
| switch (ot) | ||
| { | ||
| // TODO hardcoded types, must advance SAI repository commit to get metadata for this |
There was a problem hiding this comment.
i think this is already done, SAI repo was advanced enough to get that metadata, please use it here
| sendNotification(SAI_SWITCH_NOTIFICATION_NAME_ICMP_ECHO_SESSION_STATE_CHANGE, s); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
extra empty lines not needed
| @@ -26,6 +26,7 @@ tests_SOURCES = \ | |||
| TestNotificationSwitchAsicSdkHealthEvent.cpp \ | |||
| TestNotificationSwitchStateChange.cpp \ | |||
| TestNotificationBfdSessionStateChange.cpp \ | |||
| TestNotificationIcmpEchoSessionStateChange.cpp \ | |||
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+6918
to
+6932
| switch (ot) | ||
| { | ||
| // TODO hardcoded types, must advance SAI repository commit to get metadata for this | ||
| case SAI_OBJECT_TYPE_ICMP_ECHO_SESSION: | ||
|
|
||
| valid = true; | ||
| break; | ||
|
|
||
| default: | ||
|
|
||
| SWSS_LOG_ERROR("data.icmp_echo_session_id %s has unexpected type: %s, expected ICMP_ECHO_SESSION", | ||
| sai_serialize_object_id(data.icmp_echo_session_id).c_str(), | ||
| sai_serialize_object_type(ot).c_str()); | ||
| break; | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements Note
| { | ||
| json item; | ||
|
|
||
| item["icmp_echo"] = sai_serialize_object_id(icmp_echo_session_state[i].icmp_echo_session_id); |
There was a problem hiding this comment.
This needs to be "icmp_echo_session_id"
There was a problem hiding this comment.
Is UT covering this function? No?
manamand2020
suggested changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for ICMP_ECHO_SESSION in following areas of sonic-sairedis
meta layer
syncd
Notification Handling
added unittest to test notification and attribute handling