-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rpc server]: Enable syncd-rpc target compilation. #260
Conversation
Export switch ID variable required by SAI thrift.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need gSwitchId?
/* | ||
* SAI switch global needed for RPC server | ||
*/ | ||
sai_object_id_t gSwitchId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What component does use the gSwitchId variable ?
I see you assign some value to it below, but how it is used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is required by the latest SAI thrift implementation:
https://github.com/opencomputeproject/SAI/blob/master/test/saithrift/src/switch_sai_rpc_server.cpp#L80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd better to make interface of SAI thrift implementation more explicit by introducing
switch_id parameter to start_sai_thrift_rpc_server() function.
But anyway.
why PR build fails? what do I need to add? |
We need to reset src/SAI to 1.0.2 version. The following commit can damage the build:
If I reset the src/SAI to following commit 77b2ad2 then I have successfully built the image. |
retest this please |
@lguohan |
@lguohan |
@lguohan |
This build requires libsaithrift-dev. This library build was broken when we migrate from 0.9.4 to 1.0.2. |
Hi Guohan |
Tested and created rebased PR: #281 |
merged the #281 |
Export switch ID variable required by SAI thrift.