-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sai log level before discovery to prevent SAI ERR spam to the log #316
Merged
pavel-shirshov
merged 14 commits into
sonic-net:master
from
pavel-shirshov:pavelsh/loglevel
May 14, 2018
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3cd7a6e
Add packaging for syncd-rpc
pavel-shirshov 2de6cbe
Merge remote-tracking branch 'upstream/master'
pavel-shirshov 6f14bbe
Merge remote-tracking branch 'upstream/master'
pavel-shirshov d0b8098
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov 9ae5f1a
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov 24bca8c
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov bb6412f
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov 4887827
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov e147269
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov e4fffd2
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov 918f371
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov 548d4da
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov 7a31238
Merge branch 'master' of https://github.com/Azure/sonic-sairedis
pavel-shirshov 1e794f3
Change sai loglevel before discovery mode
pavel-shirshov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is critical ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because otherwise sai will dump to syslog many thousands of the error messages "something not found" when syncd discover sai api". Output to syslog seriously hits cpu which increases fast-reboot time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is nothing that produces critical message, so nothing would be logged except maybe something from internal sai
i would propose to log SAI_STATUS_NOT_IMPLEMENTED (which is the most errors probably) as info message in discovery method, instead of disabling all messages in this way
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Kamil,
Yes. I made that level CRITICAL because no messages are produced by SAI on syncd discovery.
I had a patch making SAI_STATUS_NOT_IMPLEMENTED as INFO in SAI. I'm not sure it's still there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea that would be better approach, so other meaningfull errors if present they still would be logged