fully support bulk_remove in sairedis #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
approved these changes
Sep 19, 2019
lguohan
pushed a commit
to sonic-net/sonic-swss-common
that referenced
this pull request
Sep 19, 2019
- consumer_table_pops.lua added bulkremove option which will DEL redis DB entries - this change is along with changes in sonic-sairedis , sonic-net/sonic-sairedis#516 Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
- add redis_dummy_remove_route_entry() for meta_sai_remove_route_entry() calls, which is the same logic as create/set - add NULL pointer check and add meta_sai_remove_route_entry() calls which will remove meta data after remove entries. The logic is the same as create/set - syncd add bulkremove option for processEvent() to select processBulkEvent() - together with this , there should be a consumer_table_pops.lua script changes to handle bulkremove in sonic_swss_common sonic-net/sonic-swss-common#306 - after these changes , when we call bulk_create and bulk_remove, the meta data is cleared and we can bulk_create again, otherwise it raise error entry already exists. Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add redis_dummy_remove_route_entry() for meta_sai_remove_route_entry() calls, which is the same logic as create/set
add NULL pointer check and add meta_sai_remove_route_entry() calls which will remove meta data after remove entries. The logic is the same as create/set
syncd add bulkremove option for processEvent() to select processBulkEvent()
together with this , there should be a consumer_table_pops.lua script changes to handle bulkremove in sonic_swss_common
add bulkremove for consumer_table_pops.lua sonic-swss-common#306
after these changes , when we call bulk_create and bulk_remove, the meta data is cleared and we can bulk_create again, otherwise it raise error entry already exists.
Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com