Revert "sonic-sairedis: Add support to sonic-sairedis for gearbox phys" #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #624
It looks like the
getSwitchType
method isn't compatible with the SKUs we use in the VS tests.https://github.com/Azure/sonic-sairedis/blob/9e2d0c437ca06240b529c3e9ef287c350c02b081/syncd/SaiSwitch.cpp#L140
Logs from https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build/1286/:
For reference we use the BCM56850 for most of the tests and the MLNX2700 for a few (like
test_mirror_ipv6_separate
).I will work on getting these tests added to the
sonic-sairedis
repo over the weekend so that these are available for PRs going forward. Sorry for the fire drill everyone!