[vs] Add workaround for clean up macsec ports #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
retest vs please |
lguohan
reviewed
Dec 18, 2020
vslib/src/MACsecManager.cpp
Outdated
| SWSS_LOG_THROW("Cannot show MACsec ports"); | ||
| // this is workaround, there was exception thrown here, and it probably | ||
| // suggest that, ip command is in place, but don't support "macsec" | ||
| SWSS_LOG_ERROR("Cannot show MACsec ports"); |
There was a problem hiding this comment.
i think this will block log analyzer, better to change to notice level.
There was a problem hiding this comment.
what log analyzer ? out internal ? do you propose warning ?
There was a problem hiding this comment.
the log analyzer in sonic-mgmt repo, it will report error when it does the vsimage check, warning should be fine.
lguohan
approved these changes
Dec 18, 2020
lguohan
pushed a commit
that referenced
this pull request
Dec 19, 2020
kktheballer
pushed a commit
to kktheballer/sonic-sairedis
that referenced
this pull request
Mar 10, 2021
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
jianyuewu
pushed a commit
to jianyuewu/sonic-sairedis
that referenced
this pull request
Feb 7, 2025
…-net#752) Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Pterosaur please address this when you will be available