Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vs]: Start syncd by passing context configuration file and global context index. #832

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

SuvarnaMeenakshi
Copy link
Contributor

#830 adds support to bring up multi-asic Virtual switch.
In multi-asic VS switch, there are multiple swss and syncd dockers. Orchagent process in each swss is started with a different hwinfo(asic_id). This PR is to ensure that context configuration is passed in syncd which has the hwinfo information with which each orchagent is started.

Signed-off-by: Suvarna Meenakshi sumeenak@microsoft.com

and global context index.

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
kcudnik
kcudnik previously approved these changes May 25, 2021
if the file is present.

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@kcudnik kcudnik merged commit 0e2105a into sonic-net:master Jun 1, 2021
SuvarnaMeenakshi added a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 1, 2021
)

hwskus.
Why I did it
For multi-asic platforms, orchagent process in swss docker is started by passing device_ids(or asic_ids).
Each swss docker starts orchagent with a different device_id. This device_id is passed as Hardware info to syncd. For syncd to start with the right hwinfo, context_config.json is passed as an argument. context_config.json file is looked up to get the hwinfo information.
sonic-sairedis PRs required for this diff to be used to bring up multi-asic VS:
sonic-net/sonic-sairedis#830
sonic-net/sonic-sairedis#832

How I did it
Add context_config.json for each asic in the same structure as provided here: https://github.com/Azure/sonic-sairedis/blob/master/lib/src/context_config.json
Each asic context_config.json will have different hwinfo string.
hwinfo string will be same as device id retrieved from asic.conf file.
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
SuvarnaMeenakshi added a commit that referenced this pull request Jul 9, 2021
SuvarnaMeenakshi added a commit that referenced this pull request Jul 11, 2021
…lobal context index. (#832)" (#859)

This reverts commit 0e2105a.
multi-asic VS with multiple swss and syncd dockers, comes up without context_config.json or hwinfo.
Just like a single asic vs, multi-asic vs will spawn multiple instances of swss and syncd with default hwinfo.
Reverting this PR as it is not required currently for multi-asic VS.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…nic-net#7697)

hwskus.
Why I did it
For multi-asic platforms, orchagent process in swss docker is started by passing device_ids(or asic_ids).
Each swss docker starts orchagent with a different device_id. This device_id is passed as Hardware info to syncd. For syncd to start with the right hwinfo, context_config.json is passed as an argument. context_config.json file is looked up to get the hwinfo information.
sonic-sairedis PRs required for this diff to be used to bring up multi-asic VS:
sonic-net/sonic-sairedis#830
sonic-net/sonic-sairedis#832

How I did it
Add context_config.json for each asic in the same structure as provided here: https://github.com/Azure/sonic-sairedis/blob/master/lib/src/context_config.json
Each asic context_config.json will have different hwinfo string.
hwinfo string will be same as device id retrieved from asic.conf file.
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
…ntext index. (sonic-net#832)

In multi-asic VS switch, there are multiple swss and syncd dockers. Orchagent process in each swss is started with a different hwinfo(asic_id). This PR is to ensure that context configuration is passed in syncd which has the hwinfo information with which each orchagent is started.
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
…lobal context index. (sonic-net#832)" (sonic-net#859)

This reverts commit 0e2105a.
multi-asic VS with multiple swss and syncd dockers, comes up without context_config.json or hwinfo.
Just like a single asic vs, multi-asic vs will spawn multiple instances of swss and syncd with default hwinfo.
Reverting this PR as it is not required currently for multi-asic VS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants