[gearbox] startup gbsyncd in sync mode in vSonic #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akokhan
reviewed
Sep 22, 2021
| @@ -33,7 +33,7 @@ def physyncd_spawn(gearbox_config): | |||
| proc_list = [] | |||
|
|
|||
| for i, phy in enumerate(gearbox_config['phys'], 1): | |||
| cmd = '/usr/bin/syncd -p /etc/sai.d/pai.profile -x /usr/share/sonic/hwsku/context_config.json -g {}"'.format(i) | |||
| cmd = '/usr/bin/syncd -s -p /etc/sai.d/pai.profile -x /usr/share/sonic/hwsku/context_config.json -g {}'.format(i) | |||
There was a problem hiding this comment.
I think -s is deprecated and -z should be used instead.
https://github.com/Azure/sonic-sairedis/blob/40e9c745aa3cfb75dbff91973d2b6dff1e3b61fb/syncd/CommandLineOptionsParser.cpp#L39
There was a problem hiding this comment.
I see. The option -s is equative to -z redis_sync, which is still used in syncd and orchagent command line parameter.
lguohan
approved these changes
Sep 30, 2021
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to startup gbsyncd in sync mode, since orchagent is using sync mode.