[Multi-asic]: Namespace support for LLDP and Sensor tables #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…form: LLDPRemManAddrTable PhysicalTableMIB PhysicalSensorTableMIB QBridgeMIBObjects Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
|
This pull request introduces 5 alerts when merging 961fc20 into c8e5757 - view on LGTM.com new alerts:
|
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
|
This pull request introduces 1 alert when merging 3ffba0e into c8e5757 - view on LGTM.com new alerts:
|
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
|
This pull request introduces 1 alert when merging 01e70be into a677876 - view on LGTM.com new alerts:
|
qiluo-msft
reviewed
May 29, 2020
|
|
||
| self.if_range = [] | ||
| self.lldp_counters = {} | ||
| for if_oid, if_name in self.oid_name_map.items(): | ||
| lldp_kvs = self.db_conn.get_all(mibs.APPL_DB, mibs.lldp_entry_table(if_name)) | ||
| lldp_kvs = Namespace.get_all_dbs(self.db_conn, mibs.APPL_DB, mibs.lldp_entry_table(if_name)) |
There was a problem hiding this comment.
get_all_dbs [](start = 33, length = 11)
dbs_get_all #Closed
qiluo-msft
reviewed
May 29, 2020
src/sonic_ax_impl/mibs/__init__.py
Outdated
| @@ -419,7 +419,11 @@ def update_data(self): | |||
| self.oid_list = [] | |||
| self.oid_map = {} | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Please resolve conflicts #Closed
qiluo-msft
reviewed
May 29, 2020
src/sonic_ax_impl/mibs/__init__.py
Outdated
| @@ -571,3 +595,22 @@ def init_namespace_sync_d_queue_tables(dbs): | |||
| port_queue_list_map.update(port_queue_list_map_ns) | |||
|
|
|||
| return port_queues_map, queue_stat_map, port_queue_list_map | |||
|
|
|||
| @staticmethod | |||
| def get_bridge_port_map_from_namespace_dbs(dbs, db_name): | |||
There was a problem hiding this comment.
get_bridge_port_map_from_namespace_dbs [](start = 8, length = 38)
dbs_get_bridge_port_map #Closed
qiluo-msft
reviewed
May 29, 2020
src/sonic_ax_impl/mibs/__init__.py
Outdated
| return if_br_oid_map | ||
|
|
||
| @staticmethod | ||
| def get_vlan_id_from_bvid_from_namespace_dbs(dbs, bvid): |
There was a problem hiding this comment.
get_vlan_id_from_bvid_from_namespace_dbs [](start = 8, length = 40)
dbs_get_vlan_id_from_bvid #Closed
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
qiluo-msft
approved these changes
May 29, 2020
abdosi
pushed a commit
that referenced
this pull request
Jul 8, 2020
* Changes in below MIB tables implementation to support multi-asic platform: LLDPRemManAddrTable PhysicalTableMIB PhysicalSensorTableMIB QBridgeMIBObjects * Fix LGTM errors. * Fix merge conflicts and fix function names as per review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SuvarnaMeenakshi sumeenak@microsoft.com
- What I did
This PR targets changes in lldp/sensor related MIB implementation for multi-asic platform.
LLDP Mgmt interface related information will be obtained from global db.
Update implementation of the following MIBS to get data from all
databases:
LLDPRemManAddrTable
PhysicalTableMIB
PhysicalSensorTableMIB
QBridgeMIBObjects
- How I did it
Modified implementation of above MIB classes to obtain data from all namespace database DBs.
- How to verify it
Verified in multi-asic platform.
Note: Requires code/test mock tables from #126
- Description for the changelog