[201911]Cherry-pick Master PR's to 201911 #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…espace.get_all() (#140) * [Namespace]: Remove key exists check in dbs_get_all to reduce time taken. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Fix as per review comment. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Minor fix. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Connect to all required namespace dbs during init and periodic sync_d functions to reduce time taken in dbs_get_all. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Change test_mibs to use generic wrapper function added. The Namespace functions will be used for both single and multi-asic platforms. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Fix review comment. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Fix as per review comment. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Remove whitespace. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Fix review comment. Avoid modifying mutable object kwargs, do a shallow copy instead. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
* [InterfacesMIB]: Fix counters in InterfacesMIB for multi-asic platforms. In multi-asic platforms SAI oid is not unique across namespace/asic. Use interface index as the key instead of using SAI oid. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * [Namespace]: Remove key exists check in dbs_get_all to reduce time taken. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> (cherry picked from commit 16f36d8) * Change the key used in if_id_map to support multi-asic platform. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Fix interface counters only for rfc2863. Do not run namespace unit-test for MIBs using SAI id as key. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Fix getting interface index in InterfacesMIB Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Remove debug print. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Remove db connect that is not required. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Modify as per review comments. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Fix as per review comment. Add a new dict of namespace:db connector for easier access. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Fix as per review comment. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Modify based on review comment. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> Co-authored-by: abdosi <58047199+abdosi@users.noreply.github.com>
abdosi
changed the title
|
I change the branch policy, and direct cherry-pick is preferred. Please check again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not able to push to branch directly so creating PR for cherry-pick
Following PR's are picked:
1 . Fix LGTM reported alert of PR#141 (#142)
2. [Namespace] Fix interfaces counters in InterfacesMIB RFC 2863 (#141)
3. [Namespace]: Fix SNMP AgentX socket connection timeout when using Namespace.get_all() (#140)