CPU Spike because of redundant and flooded keyspace notifis handled #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
|
@qiluo-msft, please review |
qiluo-msft
reviewed
Aug 3, 2021
qiluo-msft
reviewed
Aug 3, 2021
| """ | ||
| latest_update_map = {} | ||
| while True: | ||
| data, interface, if_index = poll_lldp_entry_updates(pubsub) |
There was a problem hiding this comment.
Not sure if i understood your suggestion correctly, a keyspace notif doesn't contain any info about the fields changed. Eg: __keyspace@0__:mykey del.
So, even if the lld_syncd logic was modified to send only one notif instead of mutiple. That'll be captured by this method. The actual logic of fetching the fv-pairs is in the downstream methods.
There was a problem hiding this comment.
Thanks for clarify. I see the flow is implemented inside this file, instead of using a library. Sorry for misleading.
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
|
Request for 202106 |
qiluo-msft
approved these changes
Aug 5, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 5, 2021
…230) **- What I did** Fixes [#8293](sonic-net/sonic-buildimage#8293) **- How I did it** Accumulated all the older notifications and did act only upon the latest notification discarding the others
|
@qiluo-msft, Can you backport this to 202106? |
judyjoseph
pushed a commit
that referenced
this pull request
Nov 14, 2021
…230) **- What I did** Fixes [#8293](sonic-net/sonic-buildimage#8293) **- How I did it** Accumulated all the older notifications and did act only upon the latest notification discarding the others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com
- What I did
Fixes #8293
- How I did it
Accumulated all the older notifications and did act only upon the latest notification discarding the others
- How to verify it
- Description for the changelog