Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snmp-subagent changes for bookworm upgrade #313

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

mohan-selvaraj
Copy link
Contributor

- What I did
remove loop argument from asyncio APIs

- How I did it

- How to verify it

- Description for the changelog

@mohan-selvaraj
Copy link
Contributor Author

To be combined with "bookworm container upgrade for lldp, net-snmp" PR
sonic-net/sonic-buildimage#18150

@saiarcot895
Copy link
Contributor

@qiluo-msft, could you help to review this, or assign someone to review? Some additional context: https://stackoverflow.com/a/60315290

saiarcot895
saiarcot895 previously approved these changes Mar 29, 2024
@adyeung
Copy link

adyeung commented Apr 4, 2024

@qiluo-msft @SuvarnaMeenakshi pls review this is blocking lldp bookworm migration

@saiarcot895
Copy link
Contributor

Could you include 2dbbb5c in your branch? This is to add some code coverage for these changes. This will bump up the code coverage to 83%

@mohan-selvaraj
Copy link
Contributor Author

Could you include 2dbbb5c in your branch? This is to add some code coverage for these changes. This will bump up the code coverage to 83%

Couldn't directly pull the commit. Added the changes to the branch and mentioned the commit ID in the commit message.
Thank you.

@saiarcot895 saiarcot895 merged commit f652948 into sonic-net:master Apr 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants