Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failure with unnumbered BGP neighours and don't report VLAN interfaces as down #339

Open
wants to merge 3 commits into
base: 202305
Choose a base branch
from

Conversation

SapphirusBeryl
Copy link

- What I did

  • Skip unnumbered BGP neighours instead of failing
  • Don't report VLAN interfaces as oper_down

- How I did it

  1. In case of unnumbered BGP, the neighbor is an interface.
    That can't be represented here, so just skip the neighbor.
  2. VLAN interfaces don't have an operational status, so
    return admin status for them

- How to verify it

  1. Unnumbered BGP neighours no longer trigger a failure
  2. VLAN Interfaces are no longer reported as down

- Description for the changelog

  • Skip unnumbered BGP neighours instead of failing
  • Don't report VLAN interfaces as oper_down

lukasstockner and others added 3 commits October 30, 2023 19:36
a1e11f8: Don't report VLAN interfacesas oper_down
7a88058: Skip unnumbered BGP neighbors instead of failing

Signed-off-by: Xavier Moffett <sapphirus@azorium.net>
Copy link

linux-foundation-easycla bot commented Nov 25, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@SapphirusBeryl SapphirusBeryl changed the title Fixes failure with unnumbered BGP neighours and don't report VLAN interfaces as down Fix failure with unnumbered BGP neighours and don't report VLAN interfaces as down Nov 25, 2024
@SapphirusBeryl SapphirusBeryl marked this pull request as ready for review November 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants