[swss-common] Remove object type argument from json array() constructor call #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or call. Default value set to value_t::array in constructor. Issue: sonic-net/sonic-sairedis#801 Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
|
@kcudnik . Please review. |
kcudnik
reviewed
Mar 11, 2021
| return basic_json(init, false, value_t::array); | ||
| return basic_json(init, false); |
There was a problem hiding this comment.
this is interesting, since array type was explicitly passed as argument, can you also add unittest for that scenario that was causing crash ? in this repo
There was a problem hiding this comment.
Added an UT case in file, json_ut.cpp.
…or call. Default value set to value_t::array in constructor. Issue: sonic-net/sonic-sairedis#801 Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
kcudnik
approved these changes
Mar 11, 2021
|
Pls hold on this PR. |
please diagnose and add those crashes to unittests here also when fixed |
|
this one also after verification, could be closed, since issue is most likely related to cross compiler issues on armhf |
|
closing, as this is no longer needed since issue 801 was resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value set to value_t::array in constructor.
Issue: sonic-net/sonic-sairedis#801
Signed-off-by: Rajkumar Pennadam Ramamoorthy rpennadamram@marvell.com