-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PINS] Add AppDB ACL schema values shared between the P4RT app and P4Orch #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submission containing materials of a third party: Copyright Google LLC; Licensed under Apache 2.0 Co-authored-by: Akarsh Gupta <akarshgupta@google.com> Co-authored-by: Ashish Singh <ashishksingh@google.com> Co-authored-by: Jay Hu <jiarenhu@google.com> Co-authored-by: Manali Kumar <manalikumar@google.com> Co-authored-by: Richard Yu <richardyu@google.com> Co-authored-by: Robert J. Halstead <rhalstea@google.com> Co-authored-by: Runming Wu <runmingwu@google.com> Co-authored-by: Srikishen Pondicherry Shanmugam <kishanps@google.com> Co-authored-by: Vivek Ramamoorthy <vivekmoorthy@google.com> Co-authored-by: Yilan Ji <yilanji@google.com> Signed-off-by: Don Newton don@opennetworking.org
@qiluo-msft this is related to #547 |
qiluo-msft
reviewed
Nov 11, 2021
qiluo-msft
reviewed
Nov 11, 2021
qiluo-msft
reviewed
Nov 11, 2021
qiluo-msft
reviewed
Nov 11, 2021
qiluo-msft
reviewed
Nov 11, 2021
qiluo-msft
reviewed
Nov 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As comments
2 tasks
qiluo-msft
approved these changes
Nov 12, 2021
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
@qiluo-msft, the tests are passing. I think this PR is ready to merge. |
Friendly ping ... are we able to merge this? |
Thanks @qiluo-msft! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission containing materials of a third party:
Copyright Google LLC; Licensed under Apache 2.0
Co-authored-by: Akarsh Gupta akarshgupta@google.com
Co-authored-by: Ashish Singh ashishksingh@google.com
Co-authored-by: Jay Hu jiarenhu@google.com
Co-authored-by: Manali Kumar manalikumar@google.com
Co-authored-by: Richard Yu richardyu@google.com
Co-authored-by: Robert J. Halstead rhalstea@google.com
Co-authored-by: Runming Wu runmingwu@google.com
Co-authored-by: Srikishen Pondicherry Shanmugam kishanps@google.com
Co-authored-by: Vivek Ramamoorthy vivekmoorthy@google.com
Co-authored-by: Yilan Ji yilanji@google.com
Signed-off-by: Don Newton don@opennetworking.org