Use build profiles instead of distro version for Python 2 binding build #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the distro version to determine if the Python 2 bindings should be built, use deb profiles instead to specify if they should be built or not. The main reason of this is that normal .install and .dirs files can be used for both the Python 2 and Python 3 bindings, instead of .install/.dir files for Python 3 and debian/rules for Python 2. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
changed the title
qiluo-msft
reviewed
Nov 12, 2021
.azure-pipelines/build-template.yml
Outdated
| @@ -64,7 +64,7 @@ jobs: | |||
| - script: | | |||
| set -ex | |||
| ./autogen.sh | |||
| fakeroot debian/rules DEB_CONFIGURE_EXTRA_FLAGS='--enable-code-coverage' CFLAGS="" CXXFLAGS="--coverage -fprofile-abs-path" LDFLAGS="--coverage -fprofile-abs-path" binary && cp ../*.deb . | |||
| fakeroot debian/rules DEB_CONFIGURE_EXTRA_FLAGS='--enable-code-coverage' CFLAGS="" CXXFLAGS="--coverage -fprofile-abs-path" LDFLAGS="--coverage -fprofile-abs-path" DEB_BUILD_PROFILES=python2 binary && cp ../*.deb . | |||
There was a problem hiding this comment.
There would need to be a change in rules/swss-common.mk, but slave.mk doesn't need to be fixed.
qiluo-msft
previously approved these changes
Nov 12, 2021
Because DEB_CONFIGURE_EXTRA_FLAGS is specified on the command line in swss-common CI build, that value overrides any setting in debian/rules unless override is used. Rather than using override, just make a new variable. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Debian's page on build profiles have most of the "recognized" build profiles as those disabling features, which makes sense since by default, you'd want everything enabled. Follow that scheme here as well. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
qiluo-msft
previously approved these changes
Nov 12, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…need to be changed Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Nov 19, 2021
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the distro version to determine if the Python 2
bindings should be built, use deb profiles instead to specify if they
should be built or not. The main reason of this is that normal .install
and .dirs files can be used for both the Python 2 and Python 3 bindings,
instead of .install/.dir files for Python 3 and debian/rules for Python
2.
More details on build profiles are here.
Signed-off-by: Saikrishna Arcot sarcot@microsoft.com