Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syncd crashing due to invalid length being used for string printing #806

Closed
wants to merge 1 commit into from
Closed

Fix syncd crashing due to invalid length being used for string printing #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/rediscommand.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ int RedisCommand::appendTo(redisContext *ctx) const

std::string RedisCommand::toPrintableString() const
{
return binary_to_printable(temp, len);
return binary_to_printable(temp, length());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

length

Add a unit test?

}

const char *RedisCommand::c_str() const
Expand Down
Loading