-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[schema] Support for aggregrate VOQ Counters. #855
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekverma-arista
changed the title
[ schema ] Added counters table for aggregate VOQ counters.
[schema] Added counters table for aggregate VOQ counters.
Feb 13, 2024
vivekverma-arista
changed the title
[schema] Added counters table for aggregate VOQ counters.
[schema] Support for aggregrate VOQ Counters.
Feb 18, 2024
vmittal-msft
approved these changes
May 24, 2024
@viveksrao-arista please rebase. |
Rebased the code. |
@viveksrao-arista please re-base |
This reverts commit 59928e2.
Add a global #define for the name of voq to port name table that will be added to counters DB on each chip.
vivekverma-arista
force-pushed
the
aggVoq
branch
from
July 15, 2024 06:29
b548a4a
to
0e69371
Compare
We have changed the approach to be taken, hence closing this pull request. HLD has been updated with the new approach and new PR will be opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added COUNTERS table for aggregate VOQ counters.
Aggregate VOQ counters HLD #1587
The feature has been tracked in #1543
Signed-off-by: Vivek Verma (vivekverma@arista.com)