Account for control character as part of zmq_read_part #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
liuh-80
reviewed
Aug 28, 2024
liuh-80
approved these changes
Aug 29, 2024
|
@StormLiangMS Can you please review for 202311? |
mssonicbld
pushed a commit
to mssonicbld/sonic-swss-common
that referenced
this pull request
Sep 4, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-swss-common
that referenced
this pull request
Sep 4, 2024
This was referenced Sep 4, 2024
|
Cherry-pick PR to 202311: #910 |
|
Cherry-pick PR to 202405: #911 |
|
@zbud-msft cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days. |
zbud-msft
added a commit
to zbud-msft/sonic-swss-common
that referenced
this pull request
Oct 14, 2024
bingwang-ms
pushed a commit
that referenced
this pull request
Oct 16, 2024
bingwang-ms
added
Included in 202405 Branch
and removed
Approved for 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO: 28728116
Capturing control character in do_capture as part of eventd is difficult as control character can be delayed such that we it is not sometimes caught when initially starting capture service. (SUB -> PUB (part of zmq proxy)).
Instead of dropping the control character as part of eventd do_capture, I will drop it as part of zmq_message_read which eventd calls via events_service.
LIBZMQ: Control character logic: https://github.com/zeromq/libzmq/blob/cbb9925a109152426e4a8a3f8f8eaeddc0516977/src/xsub.cpp#L102
Added UT to confirm, as well as should see success rate of sonic-mgmt testcases go up for telemetry/test_events