Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swss build fails if SAI library installed #1122

Closed
daall opened this issue Nov 8, 2019 · 1 comment · Fixed by #1123
Closed

swss build fails if SAI library installed #1122

daall opened this issue Nov 8, 2019 · 1 comment · Fixed by #1123
Labels
Bug 🐛 Testing

Comments

@daall
Copy link
Contributor

daall commented Nov 8, 2019

configure.ac only generates a Makefile for tests/mock_tests if no SAI library is installed:

# If no SAI library is installed, compile with SAIVS and run unit tests
AM_COND_IF([HAVE_SAI],[],
           [AC_CONFIG_FILES([tests/mock_tests/Makefile])])

However, the Makefile.am for tests specifies that mock_tests is to be built unconditionally:

SUBDIRS = mock_tests

As a result, when trying to build swss against a SAI library, the tests Makefile attempts to build mock_tests first, causing the build to crash.

This was introduced by #1103. We can't revert this commit because it includes a bugfix for portsorch, so we'll need to open another PR to patch this before we can update the swss submodule in sonic-buildimage.
@prsunny prsunny mentioned this issue Nov 8, 2019
Closed
@stepanblyschak
Copy link
Contributor

Please check #1123

@stepanblyschak stepanblyschak mentioned this issue Nov 8, 2019
Merged
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this issue Feb 28, 2022
@jleveque
Support building sonic-utilities as a Python wheel package instead of…
2244d7b 
… a Debian package (sonic-net#1122)

Support building sonic-utilities as a Python wheel package rather than a Debian package.

Notes:
- Wheel packaging restricts the installation of files to within the dist-packages directory. Thus, we cannot install data files to system directories. Therefore, I am building a separate 'sonic-utilities-data' package for installing the data files (bash_completion, templates)
- Wheel packages install scripts/entrypoints to the /usr/local/bin directory, whereas Debian packages install to /usr/bin
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this issue Mar 1, 2023
@mdanish-kh
[doc]: Update README.md (sonic-net#1122)
3fa8f34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐛 Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tests] fix build against real SAI stepanblyschak/sonic-swss
2 participants
@stepanblyschak @daall