Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBConnector::DBConnector classes redifined in sonic-swss again for mock_tests. #1363

Closed
judyjoseph opened this issue Jul 25, 2020 · 2 comments
Closed

DBConnector::DBConnector classes redifined in sonic-swss again for mock_tests. #1363

judyjoseph opened this issue Jul 25, 2020 · 2 comments
Assignees
@judyjoseph

Comments

@judyjoseph
Copy link
Contributor

The DBConnector class defined in the sonic-swss-common, is redefined here for the mock_tests ( tests/mock_tests/mock_dbconnector.cpp)

This needs to be revisited as when we change the DBConnector functionality in swss-common, we need to manually update the class definition in sonic-swss as well.

Would be good If here in sonic-swss, we could use the API's defined in sonic-swsscommon directly.
judyjoseph added a commit to judyjoseph/sonic-swss-common that referenced this issue Aug 3, 2020
@judyjoseph
Additional changes to overcome the issue mentioned in sonic-net/sonic…
4324228 
…-swss#1363

Also changes to allign the dbConnector class here with that of sonic-py-swssdk
   1. Ignore if the database_global.json file is not present.
   2. validate the namespace before using it.
@judyjoseph judyjoseph mentioned this issue Aug 3, 2020
Merged
@judyjoseph judyjoseph self-assigned this Aug 5, 2020
judyjoseph added a commit to sonic-net/sonic-swss-common that referenced this issue Aug 19, 2020
@judyjoseph
Dbconnector namespace support (#376)
49a7c9d 
* Adding back PR#364

* Kept the old definition of  >>DBConnector(const std::string &dbName, unsigned int timeout, bool isTcpConn = false) << intact , so that we don't the issue (sonic-net/sonic-swss#1363)

* Also changes to allign the dbConnector class here with that of sonic-py-swssdk
   1. Ignore if the database_global.json file is not present.
   2. validate the namespace before using it.

* Fixes to take care of case where certain SWSS tests where failing as they were creating DBConnector object using the earlier constructors before Multi-DB design where the first argument is dbid
eg: conf_db = swsscommon.DBConnector(swsscommon.CONFIG_DB, dvs.redis_sock, 0)

* Change the variable naming --> netns, use the old logic in newConnector()

* Couple of more testcase scenarios added.
abdosi pushed a commit to sonic-net/sonic-swss-common that referenced this issue Aug 19, 2020
@judyjoseph @abdosi
Dbconnector namespace support (#376)
a87ac4f 
* Adding back PR#364

* Kept the old definition of  >>DBConnector(const std::string &dbName, unsigned int timeout, bool isTcpConn = false) << intact , so that we don't the issue (sonic-net/sonic-swss#1363)

* Also changes to allign the dbConnector class here with that of sonic-py-swssdk
   1. Ignore if the database_global.json file is not present.
   2. validate the namespace before using it.

* Fixes to take care of case where certain SWSS tests where failing as they were creating DBConnector object using the earlier constructors before Multi-DB design where the first argument is dbid
eg: conf_db = swsscommon.DBConnector(swsscommon.CONFIG_DB, dvs.redis_sock, 0)

* Change the variable naming --> netns, use the old logic in newConnector()

* Couple of more testcase scenarios added.
@anshuv-mfst
Copy link

@judyjoseph - could you please confirm and close the issue, thanks.

@judyjoseph
Copy link
Contributor Author

Closing this one as we had added the dependency of getting the swss/sairedis/swsscommon build/test when changes made in any of the repos. Earlier this was not the case and when we modify this DBConnector API in swsscommon -- swss test was not done. Now it is fixed.

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this issue Feb 28, 2022
@vganesan-nokia
[voq/inbandif] Voq inbandif port (sonic-net#1363)
02b263a 
Inband port can be made available in PORT table. But regular port handlngs are
not applicable for Inband port. This PR has change to avoid regular port handling for inband port for route_check and sfpshow script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@judyjoseph judyjoseph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@judyjoseph @anshuv-mfst