[aclorch]: Check for existing mirror table only when creating a new table #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able Signed-off-by: Danny Allen <daall@microsoft.com>
stcheng
approved these changes
Oct 10, 2019
prsunny
approved these changes
Oct 11, 2019
stcheng
approved these changes
Oct 11, 2019
|
retest this please |
1 similar comment
|
retest this please |
lguohan
approved these changes
Oct 11, 2019
renukamanavalan
pushed a commit
that referenced
this pull request
Oct 11, 2019
…able (#1089) * Display mirror table type Signed-off-by: Danny Allen <daall@microsoft.com>
yxieca
added
Request for 201811 Branch
Included in 201811 Branch
and removed
Request for 201811 Branch
labels
yxieca
pushed a commit
that referenced
this pull request
Nov 5, 2019
…able (#1089) * Display mirror table type Signed-off-by: Danny Allen <daall@microsoft.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
- Update SAI VoQ support (sonic-net#1107) … - Voq system (sonic-net#1081) … - [meta] Add support for ignored enum values (sonic-net#1099) - TPID SAI proposal (sonic-net#1089) … - ACL GRE key match (sonic-net#1076) … - Add IPv6 NS and NA Traps (sonic-net#1092) … - MACsec flow list attribute added in MACsec object (sonic-net#1095) … - Add Enterprise Number for IPFIX Report Type (sonic-net#1072) … - Provide TTL and QoS treatment during MPLS encap and decap (sonic-net#1079) - Create and Set for Tunnel Attributes (sonic-net#1086) …
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
…ily (sonic-net#1089) * Added check if SDE profile configured * put $PROFILE_DEFAULT into quotes, removed one extra space before $PROFILE_DEFAULT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[aclorch]: Check for existing mirror table only when creating a new table
Signed-off-by: Danny Allen daall@microsoft.com
What I did
I modified aclorch to check for existing mirror tables only when creating new tables, not when modifying/replacing an existing table.
Why I did it
Configlets may modify the bindings for MIRROR tables, this change makes it easier to do so. It also makes the behavior for updates to MIRROR tables consistent with the behavior with updates for other table types.
How I verified it
I updated the bindings for the EVERFLOW ACL table and verified that the group was deleted and created, as expected.