[aclorch] if vendor does not implement ACL action capability quieries… #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - use default capabilities (do not fail) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
prsunny
approved these changes
Oct 25, 2019
orchagent/aclorch.cpp
Outdated
| } | ||
| else if (status == SAI_STATUS_NOT_IMPLEMENTED) |
There was a problem hiding this comment.
Please have just the else case to populate the default table
There was a problem hiding this comment.
I changed it. But that means SAI does not return valid status code
orchagent/aclorch.cpp
Outdated
| } | ||
|
|
||
| for (size_t i = 0; i < values.count; i++) | ||
| else if (status == SAI_STATUS_NOT_IMPLEMENTED) |
There was a problem hiding this comment.
Can you address this as well?
added 2 commits
October 28, 2019 00:01
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
prsunny
approved these changes
Oct 28, 2019
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… - use default capabilities (do not fail)
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
What I did
If ACL max action count query failed - use defaultAclActionsSupported for both INGRESS and EGRESS
If ACL actions query on INGRESS failed use defaultAclActionsSupported for INGRESS
If ACL actions query on EGRESS failed use defaultAclActionsSupported for EGRESS
Warn in any scenario that orchagent will assume defaults.
#ifdef SAI_SUPPORTS_OBJECT_API /* does not compile right now */
if enum values supported for ACL action query failed - assume all are supported
(e.g. action - PACKET_ACTION, values - DROP,FORWARD etc.)
#else
assume all values are supported
#end
Why I did it
Seems to crash on many vendors because of lack of capability query support
How I verified it
Verify on system which supports attributes,
Simulate if system does not support and verify defaults are pushed to db
Details if related