Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case #1111

Merged
merged 3 commits into from
Oct 31, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Oct 29, 2019

Signed-off-by: Wenda Ni wenni@microsoft.com

What I did

Why I did it

How I verified it

Details if related

…y non-zero case

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani requested a review from lguohan October 29, 2019 23:35
@wendani wendani changed the title Check if pfc pause is at on state over the polling period for queue occupany non-zero case Check if pfc pause is at ON state over the polling period for queue occupany non-zero case Oct 29, 2019
@wendani wendani changed the title Check if pfc pause is at ON state over the polling period for queue occupany non-zero case Check if pfc pause is at ON state over the polling period for queue occupancy non-zero case Oct 29, 2019
@wendani wendani changed the title Check if pfc pause is at ON state over the polling period for queue occupancy non-zero case [fix] Check if pfc pause is at ON state over the polling period for queue occupancy non-zero case Oct 29, 2019
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani changed the title [fix] Check if pfc pause is at ON state over the polling period for queue occupancy non-zero case [fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case Oct 30, 2019
@yxieca yxieca merged commit f09ddb4 into sonic-net:201811 Oct 31, 2019
abdosi pushed a commit that referenced this pull request May 17, 2021
…zero case as the zero case (#1111)

* Check if pfc is at on state over the polling period for queue occupany non-zero case

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Use the same condition for queue occupany zero and non-zero cases

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Remove single line comments that no longer valid
@abdosi
Copy link
Contributor

abdosi commented May 17, 2021

@lguohan/@yxieca Can you cherry-pick this in master/202012.

Have cherry-picked in 201911.

cc @neethajohn and @rlhui

qiluo-msft pushed a commit that referenced this pull request May 17, 2021
…zero case as the zero case (#1111)

* Check if pfc is at on state over the polling period for queue occupany non-zero case

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Use the same condition for queue occupany zero and non-zero cases

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Remove single line comments that no longer valid
@qiluo-msft
Copy link
Contributor

Cherry-picked into 202012

qiluo-msft pushed a commit that referenced this pull request May 17, 2021
…zero case as the zero case (#1111)

* Check if pfc is at on state over the polling period for queue occupany non-zero case

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Use the same condition for queue occupany zero and non-zero cases

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Remove single line comments that no longer valid
@qiluo-msft
Copy link
Contributor

Cherry-picked into master. Please submit PR to master in future because PR checkers are better supported on master.

@wendani
Copy link
Contributor Author

wendani commented May 19, 2021

Cherry-picked into master. Please submit PR to master in future because PR checkers are better supported on master.

🙆‍♂️

raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
…zero case as the zero case (sonic-net#1111)

* Check if pfc is at on state over the polling period for queue occupany non-zero case

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Use the same condition for queue occupany zero and non-zero cases

Signed-off-by: Wenda Ni <wenni@microsoft.com>

* Remove single line comments that no longer valid
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
Changes:
b2487f0 [saithrift] build with recent ctypes (sonic-net#1111)
298344e [saithrift]: Fix max lane per port (sonic-net#1112)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
In vs test, run 20 tests at a time instead of running all the tests together.
This may help in fixing the test issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants