-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y non-zero case Signed-off-by: Wenda Ni <wenni@microsoft.com>
wendani
changed the title
Check if pfc pause is at on state over the polling period for queue occupany non-zero case
Check if pfc pause is at ON state over the polling period for queue occupany non-zero case
Oct 29, 2019
wendani
changed the title
Check if pfc pause is at ON state over the polling period for queue occupany non-zero case
Check if pfc pause is at ON state over the polling period for queue occupancy non-zero case
Oct 29, 2019
wendani
changed the title
Check if pfc pause is at ON state over the polling period for queue occupancy non-zero case
[fix] Check if pfc pause is at ON state over the polling period for queue occupancy non-zero case
Oct 29, 2019
lguohan
approved these changes
Oct 30, 2019
Signed-off-by: Wenda Ni <wenni@microsoft.com>
wendani
changed the title
[fix] Check if pfc pause is at ON state over the polling period for queue occupancy non-zero case
[fix] Use the same storm detection condition for queue occupancy non-zero case as the zero case
Oct 30, 2019
yxieca
reviewed
Oct 30, 2019
yxieca
approved these changes
Oct 31, 2019
abdosi
pushed a commit
that referenced
this pull request
May 17, 2021
…zero case as the zero case (#1111) * Check if pfc is at on state over the polling period for queue occupany non-zero case Signed-off-by: Wenda Ni <wenni@microsoft.com> * Use the same condition for queue occupany zero and non-zero cases Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove single line comments that no longer valid
@lguohan/@yxieca Can you cherry-pick this in master/202012. Have cherry-picked in 201911. cc @neethajohn and @rlhui |
qiluo-msft
pushed a commit
that referenced
this pull request
May 17, 2021
…zero case as the zero case (#1111) * Check if pfc is at on state over the polling period for queue occupany non-zero case Signed-off-by: Wenda Ni <wenni@microsoft.com> * Use the same condition for queue occupany zero and non-zero cases Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove single line comments that no longer valid
Cherry-picked into 202012 |
qiluo-msft
pushed a commit
that referenced
this pull request
May 17, 2021
…zero case as the zero case (#1111) * Check if pfc is at on state over the polling period for queue occupany non-zero case Signed-off-by: Wenda Ni <wenni@microsoft.com> * Use the same condition for queue occupany zero and non-zero cases Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove single line comments that no longer valid
Cherry-picked into master. Please submit PR to master in future because PR checkers are better supported on master. |
🙆♂️ |
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…zero case as the zero case (sonic-net#1111) * Check if pfc is at on state over the polling period for queue occupany non-zero case Signed-off-by: Wenda Ni <wenni@microsoft.com> * Use the same condition for queue occupany zero and non-zero cases Signed-off-by: Wenda Ni <wenni@microsoft.com> * Remove single line comments that no longer valid
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Changes: b2487f0 [saithrift] build with recent ctypes (sonic-net#1111) 298344e [saithrift]: Fix max lane per port (sonic-net#1112) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
In vs test, run 20 tests at a time instead of running all the tests together. This may help in fixing the test issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenda Ni wenni@microsoft.com
What I did
Why I did it
How I verified it
Details if related