Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MultiDB]: using new APIs in orch agents and mock_tests #1138

Merged
merged 1 commit into from
Nov 26, 2019
Merged

[MultiDB]: using new APIs in orch agents and mock_tests #1138

merged 1 commit into from
Nov 26, 2019

Conversation

dzhangalibaba
Copy link
Collaborator

  • replacing old APIs with new APIs in orch agents
  • fix mock_tests cases
    • adding database_config.json
    • adding mock DBConnector(X, X)
    • using new APIs in mock_tests

Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com

@dzhangalibaba
Copy link
Collaborator Author

dzhangalibaba commented Nov 21, 2019 •
edited
Loading

@qiluo-msft
BTW for this PR, we need the latest vs docker image to pass vs tests. sonic-net/sonic-buildimage#3757 . IS the vs docker images updated automatically or we need manually update vs docker ?

qiluo-msft
qiluo-msft approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Make sure vs test pass.

@qiluo-msft
Copy link
Contributor

Retest this please

@qiluo-msft qiluo-msft requested a review from lguohan November 21, 2019 20:51
@qiluo-msft qiluo-msft mentioned this pull request Nov 21, 2019
Merged
@dzhangalibaba
Copy link
Collaborator Author

Thanks for reviewing.
FYI, I ran vs tests passed on local. Looks swss build on Jenkis failed for a while recently. Any reason ?
https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/sonic-swss-build/

Looks good to me. Make sure vs test pass.

@dzhangalibaba
Copy link
Collaborator Author

retest this please

3 similar comments
@prsunny
Copy link
Collaborator

prsunny commented Nov 23, 2019

retest this please

@dzhangalibaba
Copy link
Collaborator Author

retest this please

@dzhangalibaba
Copy link
Collaborator Author

retest this please

@dzhangalibaba
Copy link
Collaborator Author

one question， the vs tests looks having some issues itself. I run "retest this please" many times, every time , it report different failure cases. If we check two vs tests together, then all test cases are passed. Looks to pass vs tests needs luck ???

@dzhangalibaba
Copy link
Collaborator Author

retest this please

2 similar comments
@dzhangalibaba
Copy link
Collaborator Author

retest this please

@dzhangalibaba
Copy link
Collaborator Author

retest this please

@dzhangalibaba
Copy link
Collaborator Author

after several tries, vs tests passed. @qiluo-msft

@qiluo-msft qiluo-msft merged commit fc085ee into sonic-net:master Nov 26, 2019
@dzhangalibaba dzhangalibaba deleted the multidb_swss branch December 17, 2019 19:57
abdosi pushed a commit that referenced this pull request Jan 3, 2020
@dzhangalibaba @abdosi
[MultiDB]: using new APIs in orch agents and mocktest (#1138)
2412ef9
@Praveen-Brcm Praveen-Brcm mentioned this pull request Jul 9, 2021
Merged
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@gitsabari @tapashdas
@sujinmkang @shi-su
mclag enhancements as per HLD at sonic-net/SONiC#596 (sonic-net#1138)
0efd297 
* mclagsyncd enhancements as per HLD at sonic-net/SONiC#596

* addressed LGTM alert

* UT Fix unique IP configuration

* modified ip address validate function for mclag config verication

* Add soft-reboot reboot type (sonic-net#1453)

What I did
Add a new reboot named as soft-reboot which can be performed by "kexec -e"

How I did it
Replace the platform reboot with "kexec -e" for the cold reboot case.

How to verify it
Verified the reboot on DUT and check the reboot-cause

* [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (sonic-net#1460)

Check if any warm restart flag is set when issuing a warm-reboot. This check avoids starting a warm reboot while another warm restart is in progress. In the scenario where a warm reboot is issued with another warm restart in progress, the warm restart flag may be reset and part of the components have a risk of doing cold reboot.

* Added mclag config commands

* removed unwanted imports

* added mclag tests

* fixed build issue

* corrected mclag test

* corrected mclag test

* corrected mclag test case

* updated testcase for mclag

* updated mclag config

* updated mclag test cases

* updated mclag test case

* updated mclag test cases

* fixed alert

* updated mclag test cases

* updated mclag test cases

* updated mclag config

* modified mclag test cases

* updated mclag test case

* updated mclag test case

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test case

* updated mclag test case

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test case

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test cases

* updated mclag test case

* updated mclag test cases

* updated mclag test case

* updated mclag config to use swsscommon instead of swssdk

* updated mclag config to use swsscommon

* updated mclag config script file

* fixed mclag test cases to verify config db

* updated mclag test case with config db verify function

* fixed build issue

* updated test case

* updated mclag test case

* addressed review comments

Co-authored-by: Tapash Das <tapash.das@broadcom.com>
Co-authored-by: Tapash Das <48195098+tapashdas@users.noreply.github.com>
Co-authored-by: Sujin Kang <sujkang@microsoft.com>
Co-authored-by: Shi Su <67605788+shi-su@users.noreply.github.com>
@Pan-XT Pan-XT mentioned this pull request Sep 19, 2024
Merged
lguohan pushed a commit that referenced this pull request Nov 1, 2024
@Pan-XT
[MultiDB]:sonic-swss replace old API with new APIs (#3292)
368e1d6 
Replace DBConnector old APIs with new APIs to enable Multi DB

I implemented similar changes in #1138
stepanblyschak pushed a commit to stepanblyschak/sonic-swss that referenced this pull request Nov 13, 2024
@Pan-XT @stepanblyschak
[MultiDB]:sonic-swss replace old API with new APIs (sonic-net#3292)
1fca0d0 
Replace DBConnector old APIs with new APIs to enable Multi DB

I implemented similar changes in sonic-net#1138
divyachandralekha pushed a commit to divyachandralekha/sonic-swss that referenced this pull request Dec 12, 2024
@Pan-XT @divyachandralekha
[MultiDB]:sonic-swss replace old API with new APIs (sonic-net#3292)
a0f71a5 
Replace DBConnector old APIs with new APIs to enable Multi DB

I implemented similar changes in sonic-net#1138
divyachandralekha pushed a commit to divyachandralekha/sonic-swss that referenced this pull request Dec 12, 2024
@Pan-XT @divyachandralekha
[MultiDB]:sonic-swss replace old API with new APIs (sonic-net#3292)
1f699c0 
Replace DBConnector old APIs with new APIs to enable Multi DB

I implemented similar changes in sonic-net#1138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
Included in 201911 Branch request_for_201911_branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dzhangalibaba @qiluo-msft @prsunny @lguohan @abdosi