Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using PRI instead of %l to support 32 bit arch #1162

Merged
merged 2 commits into from
Mar 7, 2020

Conversation

banagiri
Copy link
Contributor

@banagiri banagiri commented Jan 2, 2020

Compiling for 32 bit arch causes compilation issue with %l variants

replace %l variants with PRI

to fix compilation for 32 bit arch

compile for 32 bit arch (marvell-armhf)

@msftclas
Copy link

msftclas commented Jan 2, 2020

CLA assistant check
All CLA requirements met.

orchagent/debug_counter/debug_counter.h Outdated Show resolved Hide resolved
@jleveque
Copy link
Contributor

Retest this please

@banagiri
Copy link
Contributor Author

Retest this please

@jleveque
we have compiled and tested this on ARM 32 bit variant and x86_64 also.

@lguohan lguohan dismissed jleveque’s stale review March 7, 2020 06:48

issue addressed

@lguohan lguohan merged commit 0acf65d into sonic-net:master Mar 7, 2020
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…onic-net#1162)


Previous code only enumerate on distinct neighbors, thus only one
port is shown for a neighbor.

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants