Define lacp key to make possible creation of two lacp channels between couple of switches #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-shirshov
commented
Jan 23, 2020
| @@ -541,6 +541,8 @@ task_process_status TeamMgr::addLag(const string &alias, int min_links, bool fal | |||
| return task_need_retry; | |||
| } | |||
|
|
|||
| m_lagKeys[alias] = m_lacp_key++; | |||
There was a problem hiding this comment.
I need to make lacp_key from portchannel name, otherwise after warm reboot we might got wrong lacp_key
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…unters. (sonic-net#1180) * Fix for Issue: sonic-net/sonic-buildimage#5655 Signed-off-by: Abhishek Dosi <abdosi@microsoft.com> * Updated the the fix for pfc/queue counters also. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: sonic-net/sonic-buildimage#4009
What I did
Added
teamdctl port config updatecommand to set lacp key. Also check why I install configuration before we add interface to a channelWhy I did it
Otherwise it's impossible to set more than 1 channel between two systems.
How I verified it
Build an image and run on my dut. Check tcpdump of lacp packets. Also portchannels must be up.
Details if related