[dvs] Refactor VLAN tests to use dvslib #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor tests to use polling interface - Refactor redundant testing methods - Reenable unstable tests Signed-off-by: Danny Allen <daall@microsoft.com>
yxieca
previously approved these changes
Apr 6, 2020
lguohan
previously approved these changes
Apr 6, 2020
tahmed-dev
previously approved these changes
Apr 6, 2020
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
lguohan
approved these changes
Apr 8, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
What I did
I refactored the VLAN tests to use the new library functions in dvslib.
Why I did it
I did it to stabilize the test suite and speed up the runtime of the VLAN tests.
How I verified it
Ran a batch of 20 tests locally, 20/20 passed (avg time ~65s).
Details if related