[dvs/chassis] Bring up SONiC interfaces in virtual chassis #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Allen <daall@microsoft.com>
|
@saravanansv can you help check too? |
zhenggen-xu
previously approved these changes
Aug 20, 2020
saravanansv
reviewed
Aug 20, 2020
daall
commented
Aug 20, 2020
saravanansv
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
What I did/why I did it
While testing sonic-net/sonic-buildimage#5192 we figured out that the port config that is generated from
port_config.inidoes not include any information about the admin status of the ports on the virtual switch.However, with this PR, ports are set to
DOWNby default in the DVS. This causes the connectivity checks intest_virtual_chassis.pyto fail indefinitely.This PR ensures that the necessary ports in the chassis are admin UP so that pings can be sent from the LC instances to the neighboring servers.
I kept mixing up which interface was which while working on this PR, so I also refactored some of the variable names to be more descriptive.
How I verified it
Ran the chassis tests against the current master
docker-sonic-vsas well as the one from sonic-net/sonic-buildimage#5192. Both are successful on all chassis topologies.Details if related